LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* ASoC: mt8192: remove unnecessary CONFIG_PM
@ 2021-11-22 16:46 Jiaxin Yu
  2021-11-22 16:46 ` [PATCH] " Jiaxin Yu
  0 siblings, 1 reply; 4+ messages in thread
From: Jiaxin Yu @ 2021-11-22 16:46 UTC (permalink / raw)
  To: broonie, matthias.bgg
  Cc: tzungbi, alsa-devel, linux-arm-kernel, linux-mediatek, linux-kernel

[PATCH] ASoC: mt8192: remove unnecessary CONFIG_PM


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ASoC: mt8192: remove unnecessary CONFIG_PM
  2021-11-22 16:46 ASoC: mt8192: remove unnecessary CONFIG_PM Jiaxin Yu
@ 2021-11-22 16:46 ` Jiaxin Yu
  2021-11-23  3:12   ` Tzung-Bi Shih
  0 siblings, 1 reply; 4+ messages in thread
From: Jiaxin Yu @ 2021-11-22 16:46 UTC (permalink / raw)
  To: broonie, matthias.bgg
  Cc: tzungbi, alsa-devel, linux-arm-kernel, linux-mediatek,
	linux-kernel, Jiaxin Yu, kernel test robot

The unnecessary conditional inclusion caused the following warning.

>> sound/soc/mediatek/mt8192/mt8192-afe-pcm.c:2368:32: warning: unused
>> variable 'mt8192_afe_pm_ops' [-Wunused-const-variable]
   static const struct dev_pm_ops mt8192_afe_pm_ops = {

Because runtime_pm already handles the case without CONFIG_PM, we
can remove CONFIG_PM condition.

Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
index 31c280339c50..e1e4ca931551 100644
--- a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
+++ b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
@@ -2381,9 +2381,7 @@ static struct platform_driver mt8192_afe_pcm_driver = {
 	.driver = {
 		   .name = "mt8192-audio",
 		   .of_match_table = mt8192_afe_pcm_dt_match,
-#ifdef CONFIG_PM
 		   .pm = &mt8192_afe_pm_ops,
-#endif
 	},
 	.probe = mt8192_afe_pcm_dev_probe,
 	.remove = mt8192_afe_pcm_dev_remove,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: mt8192: remove unnecessary CONFIG_PM
  2021-11-22 16:46 ` [PATCH] " Jiaxin Yu
@ 2021-11-23  3:12   ` Tzung-Bi Shih
  2021-11-23  9:49     ` Jiaxin Yu
  0 siblings, 1 reply; 4+ messages in thread
From: Tzung-Bi Shih @ 2021-11-23  3:12 UTC (permalink / raw)
  To: Jiaxin Yu
  Cc: broonie, matthias.bgg, alsa-devel, kernel test robot,
	linux-kernel, linux-mediatek, linux-arm-kernel

On Tue, Nov 23, 2021 at 12:48 AM Jiaxin Yu <jiaxin.yu@mediatek.com> wrote:
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Tzung-Bi Shih <tzungbi@google.com>

Could you also submit another series for the cleanup?

At least for sound/soc/mediatek/:
$ rg --files-with-matches CONFIG_PM sound/soc/mediatek/
sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c
sound/soc/mediatek/mt8173/mt8173-rt5650.c
sound/soc/mediatek/mt8173/mt8173-max98090.c
sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c
sound/soc/mediatek/mt6797/mt6797-afe-pcm.c
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
sound/soc/mediatek/mt8183/mt8183-afe-pcm.c

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: mt8192: remove unnecessary CONFIG_PM
  2021-11-23  3:12   ` Tzung-Bi Shih
@ 2021-11-23  9:49     ` Jiaxin Yu
  0 siblings, 0 replies; 4+ messages in thread
From: Jiaxin Yu @ 2021-11-23  9:49 UTC (permalink / raw)
  To: Tzung-Bi Shih
  Cc: broonie, matthias.bgg, alsa-devel, kernel test robot,
	linux-kernel, linux-mediatek, linux-arm-kernel

On Tue, 2021-11-23 at 11:12 +0800, Tzung-Bi Shih wrote:
> On Tue, Nov 23, 2021 at 12:48 AM Jiaxin Yu <jiaxin.yu@mediatek.com>
> wrote:
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> 
> Acked-by: Tzung-Bi Shih <tzungbi@google.com>
> 
> Could you also submit another series for the cleanup?
> 
> At least for sound/soc/mediatek/:
> $ rg --files-with-matches CONFIG_PM sound/soc/mediatek/
> sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c
> sound/soc/mediatek/mt8173/mt8173-rt5650.c
> sound/soc/mediatek/mt8173/mt8173-max98090.c
> sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c
> sound/soc/mediatek/mt6797/mt6797-afe-pcm.c
> sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
> sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
> sound/soc/mediatek/mt8183/mt8183-afe-pcm.c

Hi Tzung-Bi,

Ok, I will remove them from sound/soc/mediatek folder in PATCH v2.
Thank you for reminding.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-23  9:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 16:46 ASoC: mt8192: remove unnecessary CONFIG_PM Jiaxin Yu
2021-11-22 16:46 ` [PATCH] " Jiaxin Yu
2021-11-23  3:12   ` Tzung-Bi Shih
2021-11-23  9:49     ` Jiaxin Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).