LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: Adjust power key nodes
@ 2021-11-22 21:36 Jernej Skrabec
  2021-11-23 10:32 ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Jernej Skrabec @ 2021-11-22 21:36 UTC (permalink / raw)
  To: mripard, wens
  Cc: robh+dt, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
	Jernej Skrabec, Michael Klein

Several H3 and one H2+ board have power key nodes, which are slightly
off. Some are missing wakeup-source property and some have BTN_0 code
assigned instead of KEY_POWER.

Adjust them, so they can function as intended by designer.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
[BananaPi M2 Zero changes]
Signed-off-by: Michael Klein <michael@fossekall.de>
---
 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 3 ++-
 arch/arm/boot/dts/sun8i-h3-nanopi.dtsi               | 1 +
 arch/arm/boot/dts/sun8i-h3-orangepi-2.dts            | 3 ++-
 arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts           | 3 ++-
 arch/arm/boot/dts/sunxi-bananapi-m2-plus.dtsi        | 3 ++-
 arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi     | 1 +
 6 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
index 8e8634ff2f9d..d5c7b7984d85 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
@@ -52,8 +52,9 @@ gpio_keys {
 
 		sw4 {
 			label = "power";
-			linux,code = <BTN_0>;
+			linux,code = <KEY_POWER>;
 			gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 	};
 
diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi b/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
index c7c3e7d8b3c8..fc45d5aaa67f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
@@ -81,6 +81,7 @@ k1 {
 			label = "k1";
 			linux,code = <KEY_POWER>;
 			gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
index 597c425d08ec..9daffd90c12f 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
@@ -99,8 +99,9 @@ sw2 {
 
 		sw4 {
 			label = "sw4";
-			linux,code = <BTN_0>;
+			linux,code = <KEY_POWER>;
 			gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 	};
 
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
index 5aff8ecc66cb..90f75fa85e68 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
@@ -91,8 +91,9 @@ r_gpio_keys {
 
 		sw4 {
 			label = "sw4";
-			linux,code = <BTN_0>;
+			linux,code = <KEY_POWER>;
 			gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/sunxi-bananapi-m2-plus.dtsi b/arch/arm/boot/dts/sunxi-bananapi-m2-plus.dtsi
index 7a6af54dd342..d03f5853ef7b 100644
--- a/arch/arm/boot/dts/sunxi-bananapi-m2-plus.dtsi
+++ b/arch/arm/boot/dts/sunxi-bananapi-m2-plus.dtsi
@@ -82,8 +82,9 @@ gpio_keys {
 
 		sw4 {
 			label = "power";
-			linux,code = <BTN_0>;
+			linux,code = <KEY_POWER>;
 			gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 	};
 
diff --git a/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi b/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi
index c44fd726945a..9e14fe5fdcde 100644
--- a/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi
+++ b/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi
@@ -49,6 +49,7 @@ power {
 			label = "power";
 			linux,code = <KEY_POWER>;
 			gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
+			wakeup-source;
 		};
 	};
 
-- 
2.34.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes
  2021-11-22 21:36 [PATCH] ARM: dts: sun8i: Adjust power key nodes Jernej Skrabec
@ 2021-11-23 10:32 ` Maxime Ripard
  2021-11-23 16:42   ` Jernej Škrabec
  0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2021-11-23 10:32 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: wens, robh+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, Michael Klein

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

Hi,

On Mon, Nov 22, 2021 at 10:36:37PM +0100, Jernej Skrabec wrote:
> Several H3 and one H2+ board have power key nodes, which are slightly
> off. Some are missing wakeup-source property and some have BTN_0 code
> assigned instead of KEY_POWER.
> 
> Adjust them, so they can function as intended by designer.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> [BananaPi M2 Zero changes]
> Signed-off-by: Michael Klein <michael@fossekall.de>

This looks a bit weird. If Michael is the author, then his SoB should be
here first and mentioned either in From or Co-developed-by.

If you are, I'm not sure why he's mentioned?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes
  2021-11-23 10:32 ` Maxime Ripard
@ 2021-11-23 16:42   ` Jernej Škrabec
  2021-11-26 16:25     ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Jernej Škrabec @ 2021-11-23 16:42 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: wens, robh+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, Michael Klein

Hi!

Dne torek, 23. november 2021 ob 11:32:19 CET je Maxime Ripard napisal(a):
> Hi,
> 
> On Mon, Nov 22, 2021 at 10:36:37PM +0100, Jernej Skrabec wrote:
> > Several H3 and one H2+ board have power key nodes, which are slightly
> > off. Some are missing wakeup-source property and some have BTN_0 code
> > assigned instead of KEY_POWER.
> > 
> > Adjust them, so they can function as intended by designer.
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > [BananaPi M2 Zero changes]
> > Signed-off-by: Michael Klein <michael@fossekall.de>
> 
> This looks a bit weird. If Michael is the author, then his SoB should be
> here first and mentioned either in From or Co-developed-by.
> 
> If you are, I'm not sure why he's mentioned?

I'm main author and Michael just adapted BananaPi M2 Zero DT based on my 
changes. What is preferred way to mark him as co-author?

Best regards,
Jernej

> 
> Maxime
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes
  2021-11-23 16:42   ` Jernej Škrabec
@ 2021-11-26 16:25     ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2021-11-26 16:25 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: wens, robh+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, Michael Klein

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Tue, Nov 23, 2021 at 05:42:55PM +0100, Jernej Škrabec wrote:
> Hi!
> 
> Dne torek, 23. november 2021 ob 11:32:19 CET je Maxime Ripard napisal(a):
> > Hi,
> > 
> > On Mon, Nov 22, 2021 at 10:36:37PM +0100, Jernej Skrabec wrote:
> > > Several H3 and one H2+ board have power key nodes, which are slightly
> > > off. Some are missing wakeup-source property and some have BTN_0 code
> > > assigned instead of KEY_POWER.
> > > 
> > > Adjust them, so they can function as intended by designer.
> > > 
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > > [BananaPi M2 Zero changes]
> > > Signed-off-by: Michael Klein <michael@fossekall.de>
> > 
> > This looks a bit weird. If Michael is the author, then his SoB should be
> > here first and mentioned either in From or Co-developed-by.
> > 
> > If you are, I'm not sure why he's mentioned?
> 
> I'm main author and Michael just adapted BananaPi M2 Zero DT based on my 
> changes. What is preferred way to mark him as co-author?

Co-developed-by would be the way to go then

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-26 16:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 21:36 [PATCH] ARM: dts: sun8i: Adjust power key nodes Jernej Skrabec
2021-11-23 10:32 ` Maxime Ripard
2021-11-23 16:42   ` Jernej Škrabec
2021-11-26 16:25     ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).