LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2021-11-22 21:15 Stephen Rothwell
  0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2021-11-22 21:15 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Hi all,

Commit

  52e66ccaa3ca ("debug")

is missing a Signed-off-by from its author and commiter.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2021-05-21 14:42       ` Kornievskaia, Olga
@ 2021-05-21 14:53         ` J. Bruce Fields
  0 siblings, 0 replies; 24+ messages in thread
From: J. Bruce Fields @ 2021-05-21 14:53 UTC (permalink / raw)
  To: Kornievskaia, Olga
  Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List

On Fri, May 21, 2021 at 02:42:53PM +0000, Kornievskaia, Olga wrote:
> [olga] Ah, thank you for figuring it out. Do you need another version
> or can you move the line?

I've fixed it, thanks.

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2021-05-21 14:01     ` J. Bruce Fields
@ 2021-05-21 14:42       ` Kornievskaia, Olga
  2021-05-21 14:53         ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Kornievskaia, Olga @ 2021-05-21 14:42 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List



On 5/21/21, 10:01 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:

    NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.




    On Fri, May 21, 2021 at 01:55:03PM +0000, Kornievskaia, Olga wrote:
    >
    >
    > On 5/21/21, 9:51 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:
    >
    >     NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
    >
    >
    >
    >
    >     On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
    >     > Hi all,
    >     >
    >     > Commit
    >     >
    >     >   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
    >     >
    >     > is missing a Signed-off-by from its author.
    >
    >     Olga, can I add
    >
    >             Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
    >
    >     ?
    >
    > [olga] But the post/patch contains that?

    Whoops, you're right.

    > I don’t understand. Even attached file has it. I think what trips
    > these system is that I use gmail to submit patches but signed-off-by
    > is from my netapp email. Unfortunately, I have no way of submitting
    > them from netapp. So the patch is correct the automated system is
    > let's say is "too strict"?

    I'm using "git am -s" and that's not picking up your Signed-off-by line
    for some reason.  Looking at the mail....

    Oh, I see, your mail looked in part like:

      However, in order to save the client doing a COMMIT as a separate
      rpc, the server can reply back with NFS_FILE_SYNC copy. This patch
      proposed to add vfs_fsync() call at the end of the async copy.

      --- v2: moved the committed argument into the nfsd4_copy structure

      Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
      ---
       fs/nfsd/nfs4proc.c | 14 +++++++++++++-
        fs/nfsd/xdr4.h     |  1 +
         2 files changed, 14 insertions(+), 1 deletion(-)

    But git uses "---" to mark the end of the changelog.  That allows you to
    include the diffstat, or any other notes that you want included in the
    mail but not in the final changelog.

    That "v2:" note is probably also something that belongs in the mail but
    not the changelog, so in future if you just move that kind of thing to
    after the Signed-off-by line, git-am will do the right thing.

[olga] Ah, thank you for figuring it out. Do you need another version or can you move the line?

    --b.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2021-05-21 13:55   ` Kornievskaia, Olga
@ 2021-05-21 14:01     ` J. Bruce Fields
  2021-05-21 14:42       ` Kornievskaia, Olga
  0 siblings, 1 reply; 24+ messages in thread
From: J. Bruce Fields @ 2021-05-21 14:01 UTC (permalink / raw)
  To: Kornievskaia, Olga
  Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List

On Fri, May 21, 2021 at 01:55:03PM +0000, Kornievskaia, Olga wrote:
> 
> 
> On 5/21/21, 9:51 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> 
>     NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> 
> 
>     On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
>     > Hi all,
>     >
>     > Commit
>     >
>     >   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
>     >
>     > is missing a Signed-off-by from its author.
> 
>     Olga, can I add
> 
>             Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> 
>     ?
> 
> [olga] But the post/patch contains that?

Whoops, you're right.

> I don’t understand. Even attached file has it. I think what trips
> these system is that I use gmail to submit patches but signed-off-by
> is from my netapp email. Unfortunately, I have no way of submitting
> them from netapp. So the patch is correct the automated system is
> let's say is "too strict"?

I'm using "git am -s" and that's not picking up your Signed-off-by line
for some reason.  Looking at the mail....

Oh, I see, your mail looked in part like:

  However, in order to save the client doing a COMMIT as a separate
  rpc, the server can reply back with NFS_FILE_SYNC copy. This patch
  proposed to add vfs_fsync() call at the end of the async copy.
  
  --- v2: moved the committed argument into the nfsd4_copy structure
  
  Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
  ---
   fs/nfsd/nfs4proc.c | 14 +++++++++++++-
    fs/nfsd/xdr4.h     |  1 +
     2 files changed, 14 insertions(+), 1 deletion(-)

But git uses "---" to mark the end of the changelog.  That allows you to
include the diffstat, or any other notes that you want included in the
mail but not in the final changelog.

That "v2:" note is probably also something that belongs in the mail but
not the changelog, so in future if you just move that kind of thing to
after the Signed-off-by line, git-am will do the right thing.

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2021-05-21 13:50 ` J. Bruce Fields
@ 2021-05-21 13:55   ` Kornievskaia, Olga
  2021-05-21 14:01     ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Kornievskaia, Olga @ 2021-05-21 13:55 UTC (permalink / raw)
  To: J. Bruce Fields, Stephen Rothwell
  Cc: Linux Kernel Mailing List, Linux Next Mailing List



On 5/21/21, 9:51 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:

    NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.




    On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
    > Hi all,
    >
    > Commit
    >
    >   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
    >
    > is missing a Signed-off-by from its author.

    Olga, can I add

            Signed-off-by: Olga Kornievskaia <kolga@netapp.com>

    ?

[olga] But the post/patch contains that? I don’t understand. Even attached file has it. I think what trips these system is that I use gmail to submit patches but signed-off-by is from my netapp email. Unfortunately, I have no way of submitting them from netapp. So the patch is correct the automated system is let's say is "too strict"?

    --b.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2021-05-20 22:04 Stephen Rothwell
@ 2021-05-21 13:50 ` J. Bruce Fields
  2021-05-21 13:55   ` Kornievskaia, Olga
  0 siblings, 1 reply; 24+ messages in thread
From: J. Bruce Fields @ 2021-05-21 13:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Olga Kornievskaia, Linux Kernel Mailing List, Linux Next Mailing List

On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
> 
> is missing a Signed-off-by from its author.

Olga, can I add

	Signed-off-by: Olga Kornievskaia <kolga@netapp.com>

?

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2021-05-20 22:04 Stephen Rothwell
  2021-05-21 13:50 ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2021-05-20 22:04 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Olga Kornievskaia, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi all,

Commit

  ff78b9442926 ("NFSD add vfs_fsync after async copy is done")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2020-11-08 21:29 ` J. Bruce Fields
@ 2020-11-09  9:15   ` Dan Carpenter
  0 siblings, 0 replies; 24+ messages in thread
From: Dan Carpenter @ 2020-11-09  9:15 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List

On Sun, Nov 08, 2020 at 04:29:36PM -0500, J. Bruce Fields wrote:
> On Mon, Nov 09, 2020 at 08:20:32AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")
> > 
> > is missing a Signed-off-by from its author.
> 
> I split the original patch in 2 and fixed a bug in this second patch,
> but unless I hear otherwise I'll assume Dan's OK with his Signed-off-by
> staying on both....

Yep.  Thanks!

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2020-11-08 21:20 Stephen Rothwell
@ 2020-11-08 21:29 ` J. Bruce Fields
  2020-11-09  9:15   ` Dan Carpenter
  0 siblings, 1 reply; 24+ messages in thread
From: J. Bruce Fields @ 2020-11-08 21:29 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Dan Carpenter, Linux Kernel Mailing List, Linux Next Mailing List

On Mon, Nov 09, 2020 at 08:20:32AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")
> 
> is missing a Signed-off-by from its author.

I split the original patch in 2 and fixed a bug in this second patch,
but unless I hear otherwise I'll assume Dan's OK with his Signed-off-by
staying on both....

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2020-11-08 21:20 Stephen Rothwell
  2020-11-08 21:29 ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2020-11-08 21:20 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Dan Carpenter, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi all,

Commit

  bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2019-12-21  3:10 Stephen Rothwell
  0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2019-12-21  3:10 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Adamson,
	Olga Kornievskaia

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi all,

Commit

  51100d2b87cb ("NFSD generalize nfsd4_compound_state flag names")

is missing a Signed-off-by from its author.

Commits

  ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy")
  b9e8638e3d9e ("NFSD: allow inter server COPY to have a STALE source server fh")
  51100d2b87cb ("NFSD generalize nfsd4_compound_state flag names")
  b7342204253a ("NFSD check stateids against copy stateids")
  624322f1adc5 ("NFSD add COPY_NOTIFY operation")
  51911868fc62 ("NFSD COPY_NOTIFY xdr")
  84e1b21d5ec4 ("NFSD add ca_source_server<> to COPY")
  af76fc6c158d ("NFSD fill-in netloc4 structure")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2019-12-02 20:38 Stephen Rothwell
  0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2019-12-02 20:38 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Olga Kornievskaia, Andy Adamson, Olga Kornievskaia

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  dd4320a29d65 ("NFSD generalize nfsd4_compound_state flag names")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2018-02-23 12:41     ` James Ettle
@ 2018-02-23 15:20       ` J. Bruce Fields
  0 siblings, 0 replies; 24+ messages in thread
From: J. Bruce Fields @ 2018-02-23 15:20 UTC (permalink / raw)
  To: James Ettle
  Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List

On Fri, Feb 23, 2018 at 12:41:05PM +0000, James Ettle wrote:
> I'm OK with that. (This is the first time I've ventured into kernel space so I thought it better to at least sketch a solution and let the experts do it correctly ;) Glad it's passed the review!)

OK, thanks!--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2018-02-23  1:05   ` J. Bruce Fields
@ 2018-02-23 12:41     ` James Ettle
  2018-02-23 15:20       ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: James Ettle @ 2018-02-23 12:41 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List

Hello,

I'm OK with that. (This is the first time I've ventured into kernel space so I thought it better to at least sketch a solution and let the experts do it correctly ;) Glad it's passed the review!)

Thanks,
James.

On 23 February 2018 01:05:45 GMT+00:00, "J. Bruce Fields" <bfields@fieldses.org> wrote:
>On Thu, Feb 22, 2018 at 06:39:43AM +0000, James Ettle wrote:
>> I only really posted this as a demo of a fix. I was hoping someone
>who actually knows what they're doing in the kernel would pick it up
>and make it proper.
>
>Whoops, sorry, I didn't realize that.
>
>But I don't see a problem with the patch as it is.  Are you OK with me
>adding your signed-off-by?
>
>--b.
>
>> 
>> Thanks,
>> James.
>> 
>> 
>> On 22 February 2018 04:17:23 GMT+00:00, Stephen Rothwell
><sfr@canb.auug.org.au> wrote:
>> >Hi,
>> >
>> >Commit
>> >
>> >  35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")
>> >
>> >is missing a Signed-off-by from its author.
>> >
>> >-- 
>> >Cheers,
>> >Stephen Rothwell

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
       [not found] ` <12138EE4-77CA-480F-B2F9-B4C7E4E20891@ettle.org.uk>
@ 2018-02-23  1:05   ` J. Bruce Fields
  2018-02-23 12:41     ` James Ettle
  0 siblings, 1 reply; 24+ messages in thread
From: J. Bruce Fields @ 2018-02-23  1:05 UTC (permalink / raw)
  To: James Ettle
  Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List

On Thu, Feb 22, 2018 at 06:39:43AM +0000, James Ettle wrote:
> I only really posted this as a demo of a fix. I was hoping someone who actually knows what they're doing in the kernel would pick it up and make it proper.

Whoops, sorry, I didn't realize that.

But I don't see a problem with the patch as it is.  Are you OK with me
adding your signed-off-by?

--b.

> 
> Thanks,
> James.
> 
> 
> On 22 February 2018 04:17:23 GMT+00:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >Hi,
> >
> >Commit
> >
> >  35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")
> >
> >is missing a Signed-off-by from its author.
> >
> >-- 
> >Cheers,
> >Stephen Rothwell

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2018-02-22  4:17 Stephen Rothwell
       [not found] ` <12138EE4-77CA-480F-B2F9-B4C7E4E20891@ettle.org.uk>
  0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2018-02-22  4:17 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, James Ettle

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

Hi,

Commit

  35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2017-11-28  1:38 ` J. Bruce Fields
@ 2017-11-28  2:02   ` Stephen Rothwell
  0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2017-11-28  2:02 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Naofumi Honda, Jeff Layton

Hi Bruce,

On Mon, 27 Nov 2017 20:38:40 -0500 "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> I rebased (probably unnecessarily, sorry), so your scripts probably
> caught this as a new commit.

Ah, OK, sorry for the noise.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2017-11-27 22:52 Stephen Rothwell
@ 2017-11-28  1:38 ` J. Bruce Fields
  2017-11-28  2:02   ` Stephen Rothwell
  0 siblings, 1 reply; 24+ messages in thread
From: J. Bruce Fields @ 2017-11-28  1:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Naofumi Honda, Jeff Layton

On Tue, Nov 28, 2017 at 09:52:56AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
> 
> Commit
> 
>   64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")
> 
> is missing a Signed-off-by from its author.

Previously:

	http://lkml.kernel.org/r/20171109200609.GM8773@fieldses.org

	It fixes a typo in two lines in pretty much the only way
	possible, so there should not be copyright concerns.

	Naofumi Honda is as far as I know a one-time contributor, and
	I'd prefer not to burden such folks with unnecessary
	bureaucracy.

I rebased (probably unnecessarily, sorry), so your scripts probably
caught this as a new commit.

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2017-11-27 22:52 Stephen Rothwell
  2017-11-28  1:38 ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2017-11-27 22:52 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Naofumi Honda, Jeff Layton

Hi Bruce,

Commit

  64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2017-11-09 19:51 Stephen Rothwell
@ 2017-11-09 20:06 ` J. Bruce Fields
  0 siblings, 0 replies; 24+ messages in thread
From: J. Bruce Fields @ 2017-11-09 20:06 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Naofumi Honda, Jeff Layton

On Fri, Nov 10, 2017 at 06:51:35AM +1100, Stephen Rothwell wrote:
> Hi,
> 
> Commit
> 
>   988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")
> 
> is missing a Signed-off-by from its author.

It fixes a typo in two lines in pretty much the only way possible, so
there should not be copyright concerns.

Naofumi Honda is as far as I know a one-time contributor, and I'd prefer
not to burden such folks with unnecessary bureaucracy.

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2017-11-09 19:51 Stephen Rothwell
  2017-11-09 20:06 ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2017-11-09 19:51 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Naofumi Honda, Jeff Layton

Hi,

Commit

  988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2017-08-25  2:21 ` J. Bruce Fields
@ 2017-08-25  2:37   ` J. Bruce Fields
  0 siblings, 0 replies; 24+ messages in thread
From: J. Bruce Fields @ 2017-08-25  2:37 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On Thu, Aug 24, 2017 at 10:21:41PM -0400, J. Bruce Fields wrote:
> On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> > Hi Bruce,
> > 
> > Commit
> > 
> >   1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
> > 
> > is missing a Signed-off-by from its author and committer.
> 
> Fixed, thanks.--b.

And, sorry, somehow I lost your other message, but: the compiler errors
should also have been fixed.  (As should be the testing error that let
them slip through--I thought I had CONFIG_NFSD_PNFS turned on in my
testing, but I didn't.)

--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the nfsd tree
  2017-08-24 22:48 Stephen Rothwell
@ 2017-08-25  2:21 ` J. Bruce Fields
  2017-08-25  2:37   ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: J. Bruce Fields @ 2017-08-25  2:21 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> Hi Bruce,
> 
> Commit
> 
>   1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
> 
> is missing a Signed-off-by from its author and committer.

Fixed, thanks.--b.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* linux-next: Signed-off-by missing for commit in the nfsd tree
@ 2017-08-24 22:48 Stephen Rothwell
  2017-08-25  2:21 ` J. Bruce Fields
  0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2017-08-24 22:48 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi Bruce,

Commit

  1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2021-11-22 21:15 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 21:15 linux-next: Signed-off-by missing for commit in the nfsd tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2021-05-20 22:04 Stephen Rothwell
2021-05-21 13:50 ` J. Bruce Fields
2021-05-21 13:55   ` Kornievskaia, Olga
2021-05-21 14:01     ` J. Bruce Fields
2021-05-21 14:42       ` Kornievskaia, Olga
2021-05-21 14:53         ` J. Bruce Fields
2020-11-08 21:20 Stephen Rothwell
2020-11-08 21:29 ` J. Bruce Fields
2020-11-09  9:15   ` Dan Carpenter
2019-12-21  3:10 Stephen Rothwell
2019-12-02 20:38 Stephen Rothwell
2018-02-22  4:17 Stephen Rothwell
     [not found] ` <12138EE4-77CA-480F-B2F9-B4C7E4E20891@ettle.org.uk>
2018-02-23  1:05   ` J. Bruce Fields
2018-02-23 12:41     ` James Ettle
2018-02-23 15:20       ` J. Bruce Fields
2017-11-27 22:52 Stephen Rothwell
2017-11-28  1:38 ` J. Bruce Fields
2017-11-28  2:02   ` Stephen Rothwell
2017-11-09 19:51 Stephen Rothwell
2017-11-09 20:06 ` J. Bruce Fields
2017-08-24 22:48 Stephen Rothwell
2017-08-25  2:21 ` J. Bruce Fields
2017-08-25  2:37   ` J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).