LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
@ 2021-11-25  9:06 Colin Ian King
  2021-11-26  5:28 ` Muchun Song
  2021-11-26  8:15 ` Joe Perches
  0 siblings, 2 replies; 5+ messages in thread
From: Colin Ian King @ 2021-11-25  9:06 UTC (permalink / raw)
  To: Andrew Morton, linux-mm; +Cc: kernel-janitors, linux-kernel

There is a spelling mistake in a literal string and a comment. Fix them.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 mm/hugetlb_cgroup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
index 9bdcf6560849..9eebe8df3c39 100644
--- a/mm/hugetlb_cgroup.c
+++ b/mm/hugetlb_cgroup.c
@@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
 	 * The hierarchical total is pretty much the value recorded by the
 	 * counter, so use that.
 	 */
-	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
+	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
 		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
 
 	/*
-	 * For each node, transverse the css tree to obtain the hierarichal
+	 * For each node, transverse the css tree to obtain the hierarchical
 	 * node usage.
 	 */
 	for_each_node_state(nid, N_MEMORY) {
-- 
2.33.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
  2021-11-25  9:06 [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical" Colin Ian King
@ 2021-11-26  5:28 ` Muchun Song
  2021-11-26  8:15 ` Joe Perches
  1 sibling, 0 replies; 5+ messages in thread
From: Muchun Song @ 2021-11-26  5:28 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Andrew Morton, Linux Memory Management List, kernel-janitors, LKML

On Thu, Nov 25, 2021 at 5:16 PM Colin Ian King
<colin.i.king@googlemail.com> wrote:
>
> There is a spelling mistake in a literal string and a comment. Fix them.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
  2021-11-25  9:06 [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical" Colin Ian King
  2021-11-26  5:28 ` Muchun Song
@ 2021-11-26  8:15 ` Joe Perches
  2021-11-26  8:29   ` Colin King (gmail)
  1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2021-11-26  8:15 UTC (permalink / raw)
  To: Colin Ian King, Andrew Morton, linux-mm; +Cc: kernel-janitors, linux-kernel

On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
> There is a spelling mistake in a literal string and a comment. Fix them.
[]
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
[]
> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
>  	 * The hierarchical total is pretty much the value recorded by the
>  	 * counter, so use that.
>  	 */
> -	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
> +	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
>  		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);

Not sure this should be changed as seq output is nominally ABI.

>  
>  	/*
> -	 * For each node, transverse the css tree to obtain the hierarichal
> +	 * For each node, transverse the css tree to obtain the hierarchical

Fixing the comment typo is good.  Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
  2021-11-26  8:15 ` Joe Perches
@ 2021-11-26  8:29   ` Colin King (gmail)
  2021-11-26  8:57     ` Muchun Song
  0 siblings, 1 reply; 5+ messages in thread
From: Colin King (gmail) @ 2021-11-26  8:29 UTC (permalink / raw)
  To: Joe Perches, Colin Ian King, Andrew Morton, linux-mm
  Cc: kernel-janitors, linux-kernel

On 26/11/2021 08:15, Joe Perches wrote:
> On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
>> There is a spelling mistake in a literal string and a comment. Fix them.
> []
>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> []
>> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
>>   	 * The hierarchical total is pretty much the value recorded by the
>>   	 * counter, so use that.
>>   	 */
>> -	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
>> +	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
>>   		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> 
> Not sure this should be changed as seq output is nominally ABI.

This just landed in linux-next, so I doubt many folk are using it. Let's 
fix it before it lands mainline.

> 
>>   
>>   	/*
>> -	 * For each node, transverse the css tree to obtain the hierarichal
>> +	 * For each node, transverse the css tree to obtain the hierarchical
> 
> Fixing the comment typo is good.  Thanks.
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
  2021-11-26  8:29   ` Colin King (gmail)
@ 2021-11-26  8:57     ` Muchun Song
  0 siblings, 0 replies; 5+ messages in thread
From: Muchun Song @ 2021-11-26  8:57 UTC (permalink / raw)
  To: Colin King (gmail)
  Cc: Joe Perches, Andrew Morton, Linux Memory Management List,
	kernel-janitors, LKML

On Fri, Nov 26, 2021 at 4:38 PM Colin King (gmail)
<colin.i.king@googlemail.com> wrote:
>
> On 26/11/2021 08:15, Joe Perches wrote:
> > On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
> >> There is a spelling mistake in a literal string and a comment. Fix them.
> > []
> >> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> > []
> >> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
> >>       * The hierarchical total is pretty much the value recorded by the
> >>       * counter, so use that.
> >>       */
> >> -    seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
> >> +    seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
> >>                 page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> >
> > Not sure this should be changed as seq output is nominally ABI.
>
> This just landed in linux-next, so I doubt many folk are using it. Let's
> fix it before it lands mainline.

Totally agree.

>
> >
> >>
> >>      /*
> >> -     * For each node, transverse the css tree to obtain the hierarichal
> >> +     * For each node, transverse the css tree to obtain the hierarchical
> >
> > Fixing the comment typo is good.  Thanks.
> >
> >
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-26  9:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25  9:06 [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical" Colin Ian King
2021-11-26  5:28 ` Muchun Song
2021-11-26  8:15 ` Joe Perches
2021-11-26  8:29   ` Colin King (gmail)
2021-11-26  8:57     ` Muchun Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).