LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/4] IB/mthca: Cleanup and optimize a few bitmap operation
Date: Thu, 25 Nov 2021 13:30:39 -0400	[thread overview]
Message-ID: <20211125173039.GA499138@nvidia.com> (raw)
In-Reply-To: <cover.1637785902.git.christophe.jaillet@wanadoo.fr>

On Wed, Nov 24, 2021 at 09:40:09PM +0100, Christophe JAILLET wrote:
> Patch 1 and 2 are just cleanups that uses 'bitmap_zalloc()' and 'bitmap_set()'
> instead of hand-writing these functions.
> 
> Patch 3 and 4 are more questionable. They replace calls to '[set|clear]_bit()'
> by their non-atomic '__[set|clear]_bit()' alternatives.
> In both files, it looks safe to do so because accesses to the corresponding
> bitmaps are protected by spinlocks.
> However, these patches are compile tested only. It not sure it worth changing the
> code just for saving a few atomic operations.
> So review, test and apply only if it make sense.
> 
> Christophe JAILLET (4):
>   IB/mthca: Use bitmap_zalloc() when applicable
>   IB/mthca: Use bitmap_set() when applicable
>   IB/mthca: Use non-atomic bitmap functions when possible in
>     'mthca_allocator.c'
>   IB/mthca: Use non-atomic bitmap functions when possible in
>     'mthca_mr.c'

Applied to for-next, thanks

Jason

      parent reply	other threads:[~2021-11-25 17:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 20:40 Christophe JAILLET
2021-11-24 20:40 ` [PATCH 1/4] IB/mthca: Use bitmap_zalloc() when applicable Christophe JAILLET
2021-11-24 20:41 ` [PATCH 2/4] IB/mthca: Use bitmap_set() " Christophe JAILLET
2021-11-24 20:42 ` [PATCH 3/4] IB/mthca: Use non-atomic bitmap functions when possible in 'mthca_allocator.c' Christophe JAILLET
2021-11-24 20:43 ` [PATCH 4/4] IB/mthca: Use non-atomic bitmap functions when possible in 'mthca_mr.c' Christophe JAILLET
2021-11-25 17:30 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211125173039.GA499138@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dledford@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --subject='Re: [PATCH 0/4] IB/mthca: Cleanup and optimize a few bitmap operation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).