[PATCH v5] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

[PATCH v5] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

[Alberto Merciai]

Replace camelcase variable "uCurrRSSI" (current Received Signal Strength
Indicator) into linux kernel coding style equivalent
variable "current_rssi".

Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
---

v4
- rebase against the staging-next
v3
- change tab with whitespace next to current_rssi
v2
- correct mailing list
v1
- remove whitespaces

 drivers/staging/vt6655/device.h      | 2 +-
 drivers/staging/vt6655/device_main.c | 4 ++--
 drivers/staging/vt6655/dpc.c         | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 3768791d9744..ff171acc11f4 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -165,7 +165,7 @@ struct vnt_private {
 	unsigned char abyCurrentNetAddr[ETH_ALEN]; __aligned(2)
 	bool bLinkPass;          /* link status: OK or fail */
 
-	unsigned int	uCurrRSSI;
+	unsigned int current_rssi;
 	unsigned char byCurrSQ;
 
 	unsigned long dwTxAntennaSel;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index e74caf22d75a..1f98f2b069c4 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -980,10 +980,10 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
 	if (priv->hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
 		return;
 
-	if (!(priv->vif->bss_conf.assoc && priv->uCurrRSSI))
+	if (!(priv->vif->bss_conf.assoc && priv->current_rssi))
 		return;
 
-	RFvRSSITodBm(priv, (u8)priv->uCurrRSSI, &dbm);
+	RFvRSSITodBm(priv, (u8)priv->current_rssi, &dbm);
 
 	for (i = 0; i < BB_VGA_LEVEL; i++) {
 		if (dbm < priv->dbm_threshold[i]) {
diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
index a7d1d35de5d4..c6ed3537f439 100644
--- a/drivers/staging/vt6655/dpc.c
+++ b/drivers/staging/vt6655/dpc.c
@@ -80,7 +80,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,
 	RFvRSSITodBm(priv, *rssi, &rx_dbm);
 
 	priv->byBBPreEDRSSI = (u8)rx_dbm + 1;
-	priv->uCurrRSSI = *rssi;
+	priv->current_rssi = *rssi;
 
 	skb_pull(skb, 4);
 	skb_trim(skb, frame_size);
-- 
2.25.1

Re: [PATCH v5] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

[Greg KH]

On Thu, Nov 18, 2021 at 10:16:59PM +0100, Alberto Merciai wrote:
> Replace camelcase variable "uCurrRSSI" (current Received Signal Strength
> Indicator) into linux kernel coding style equivalent
> variable "current_rssi".
> 
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
> ---
> 
> v4
> - rebase against the staging-next

Is this v4 or v5?

Subject says v5, but this says v4 and then you sent v4 two days later?

I'm totally lost, sorry.
Please resend this again and properly set the version number.

thanks,

greg k-h

Re: [PATCH v5] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

[Alberto Merciai]

> I'm totally lost, sorry.
I did a bit confusion, I'm lost too... :P

> Please resend this again and properly set the version number.
Sure, I will.

Thanks,
Alberto

Re: [PATCH v5] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi

[Alberto Merciai]

> Is this v4 or v5?
My fault is v6, sorry.

> Subject says v5, but this says v4 and then you sent v4 two days later?
> 
> I'm totally lost, sorry.
> Please resend this again and properly set the version number.
To be honest I'm a bit lost too :P 
I will resend the patch with the correct version.

Thanks,
Alberto