LKML Archive on
help / color / mirror / Atom feed
* [PATCH] kselftest: Fix vdso_test_time to pass on skips
@ 2021-11-26 10:28 Cristian Marussi
  0 siblings, 0 replies; only message in thread
From: Cristian Marussi @ 2021-11-26 10:28 UTC (permalink / raw)
  To: linux-kselftest, linux-kernel; +Cc: vincenzo.frascino, shuah, Cristian Marussi

When a vDSO symbol is not found, all the testcases in vdso_test_abi usually
report a SKIP, which, in turn, is reported back to Kselftest as a PASS.

Testcase vdso_test_time, instead, reporting a SKIP, causes the whole set of
tests within vdso_test_abi to be considered FAIL when symbol is not found.

Fix it reporting a PASS when vdso_test_time cannot find the vdso symbol.

Signed-off-by: Cristian Marussi <>
Seen as a failure on both a JUNO and a Dragonboard on both recent and old

root@deb-buster-arm64:~# /opt/ksft/vDSO/vdso_test_abi
[vDSO kselftest] VDSO_VERSION: LINUX_2.6.39
The time is 1637922136.675304
The time is 1637922136.675361000
The resolution is 0 1
The time is 1927.760604900
The resolution is 0 1
The time is 1637922136.675649700
The resolution is 0 1
clock_id: CLOCK_TAI [PASS]
The time is 1637922136.672000000
The resolution is 0 4000000
The time is 1927.761005600
The resolution is 0 1
The time is 1927.761132780
The resolution is 0 1
The time is 1927.757093740
The resolution is 0 4000000
Could not find __kernel_time              <<< This caused a FAIL as a whole
root@deb-buster-arm64:~# echo $?

 tools/testing/selftests/vDSO/vdso_test_abi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/vDSO/vdso_test_abi.c b/tools/testing/selftests/vDSO/vdso_test_abi.c
index 3d603f1394af..7dcc66d1cecf 100644
--- a/tools/testing/selftests/vDSO/vdso_test_abi.c
+++ b/tools/testing/selftests/vDSO/vdso_test_abi.c
@@ -90,8 +90,9 @@ static int vdso_test_time(void)
 		(vdso_time_t)vdso_sym(version, name[2]);
 	if (!vdso_time) {
+		/* Skip if symbol not found: consider skipped tests as passed */
 		printf("Could not find %s\n", name[2]);
-		return KSFT_SKIP;
+		return KSFT_PASS;
 	long ret = vdso_time(NULL);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-26 10:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 10:28 [PATCH] kselftest: Fix vdso_test_time to pass on skips Cristian Marussi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).