LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH] ARM: dts: Fix timer regression for beagleboard revision c
Date: Sun, 12 Dec 2021 21:04:55 +0200	[thread overview]
Message-ID: <20211212190455.qbggbhmr5nquw7bw@bitmer.com> (raw)
In-Reply-To: <ef843afa-c99d-328d-853a-00ef293a47f2@bitmer.com>

On Sat, Dec 11, 2021 at 05:30:57PM +0200, Jarkko Nikula wrote:
> Hi Tony
> 
> On 11/25/21 16:48, Tony Lindgren wrote:
> > Commit e428e250fde6 ("ARM: dts: Configure system timers for omap3")
> > caused a timer regression for beagleboard revision c where the system
> > clockevent stops working if omap3isp module is unloaded.
> > 
> > Turns out we still have beagleboard revisions a-b4 capacitor c70 quirks
> > applied that limit the usable timers for no good reason. This also affects
> > the power management as we use the system clock instead of the 32k clock
> > source.
> > 
> > Let's fix the issue by adding a new omap3-beagle-ab4.dts for the old timer
> > quirks. This allows us to remove the timer quirks for later beagleboard
> > revisions. We also need to update the related timer quirk check for the
> > correct compatible property.
> > 
> > Fixes: e428e250fde6 ("ARM: dts: Configure system timers for omap3")
> > Cc: linux-kernel@vger.kernel.org
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Reported-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> 
> >  .../devicetree/bindings/arm/omap/omap.txt     |  3 ++
> >  arch/arm/boot/dts/Makefile                    |  1 +
> >  arch/arm/boot/dts/omap3-beagle-ab4.dts        | 47 +++++++++++++++++++
> >  arch/arm/boot/dts/omap3-beagle.dts            | 33 -------------
> >  drivers/clocksource/timer-ti-dm-systimer.c    |  2 +-
> >  5 files changed, 52 insertions(+), 34 deletions(-)
> >  create mode 100644 arch/arm/boot/dts/omap3-beagle-ab4.dts
> > 
> I must have some error in my methodology since I cannot see the issue
> being fixed with your patch :-(
> 
Facepalm, as I was expecting I had error in my methodology... see below

> cat arch/arm/boot/dts/omap3-beagle.dtb >>arch/arm/boot/zImage

This I used years before your patch and by some reason I confused to use
new omap3-beagle-ab4.dtb when testing your patch yesterday:

> cat arch/arm/boot/dts/omap3-beagle-ab4.dtb >>arch/arm/boot/zImage

without realizing my Beagle Board version is not between A to B4 but C2.
So when using the omap3-beagle.dtb your patch fixes the regression I
found.

Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>

  reply	other threads:[~2021-12-12 19:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 14:48 Tony Lindgren
2021-11-28 18:43 ` Jarkko Nikula
2021-11-29  9:56 ` Daniel Lezcano
2021-11-29 13:30   ` Tony Lindgren
2021-12-11 15:30 ` Jarkko Nikula
2021-12-12 19:04   ` Jarkko Nikula [this message]
2021-12-13  5:43     ` Tony Lindgren
2021-12-17 12:17       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211212190455.qbggbhmr5nquw7bw@bitmer.com \
    --to=jarkko.nikula@bitmer.com \
    --cc=bcousson@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH] ARM: dts: Fix timer regression for beagleboard revision c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).