LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-01-27 16:13 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-01-27 16:13 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 8 months ago
config: microblaze-randconfig-m031-20220127 (https://download.01.org/0day-ci/archive/20220128/202201280013.Y65nbcSD-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
arch/microblaze/include/asm/thread_info.h:91 current_thread_info() error: uninitialized symbol 'sp'.
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-05-03 3:38 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-05-03 3:38 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9050ba3a61a4b5bd84c2cde092a100404f814f31
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 11 months ago
config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205031153.oyQ1vVL3-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1909 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-04-23 11:32 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-23 11:32 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c00c5e1d157bec0ef0b0b59aa5482eb8dc7e8e49
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 10 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220423/202204231946.6dxI8t51-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-04-22 8:35 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-22 8:35 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d569e86915b7f2f9795588591c8d5ea0b66481cb
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 10 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220422/202204221657.8wmjvLQj-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-04-21 6:44 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-21 6:44 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b253435746d9a4a701b5f09211b9c14d3370d0da
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 10 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220421/202204211011.FHYvcCPz-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-04-19 23:50 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-19 23:50 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 559089e0a93d44280ec3ab478830af319c56dbe3
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 10 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220420/202204200707.L7roE4go-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-04-18 8:51 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-18 8:51 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b2d229d4ddb17db541098b83524d901257e93845
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 10 months ago
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220418/202204181659.KoFawAGX-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2022-03-31 20:18 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-03-31 20:18 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 787af64d05cd528aac9ad16752d11bb1c6061bb9
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 10 months ago
config: mips-randconfig-m031-20220331 (https://download.01.org/0day-ci/archive/20220401/202204010433.RPAzSi9S-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1909 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2021-11-14 3:42 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2021-11-14 3:42 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
[-- Attachment #1: Type: text/plain, Size: 2696 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c8c109546a19613d323a319d0c921cb1f317e629
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 5 months ago
config: powerpc-randconfig-m031-20211016 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38747 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
@ 2021-08-05 8:36 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2021-08-05 8:36 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: kbuild-all, linux-kernel, Kalle Valo
[-- Attachment #1: Type: text/plain, Size: 2693 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 251a1524293d0a90c4d5060f65f42a3016280049
commit: bedf1169bcae2f762b37d40dc9db648fe7ad1952 wcn36xx: Add GTK offload info to WoWLAN resume
date: 7 weeks ago
config: x86_64-randconfig-m001-20210805 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
Old smatch warnings:
drivers/net/wireless/ath/wcn36xx/smd.c:525 wcn36xx_smd_load_nv() error: we previously assumed 'wcn->nv' could be null (see line 516)
drivers/net/wireless/ath/wcn36xx/smd.c:1908 wcn36xx_smd_send_beacon() warn: potential spectre issue 'msg_body.beacon' [w]
vim +2921 drivers/net/wireless/ath/wcn36xx/smd.c
2896
2897 static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
2898 struct ieee80211_vif *vif)
2899 {
2900 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2901 struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *rsp;
2902 __be64 replay_ctr;
2903
2904 if (wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len))
2905 return -EIO;
2906
2907 rsp = (struct wcn36xx_hal_gtk_offload_get_info_rsp_msg *)wcn->hal_buf;
2908
2909 if (rsp->bss_index != vif_priv->bss_index) {
2910 wcn36xx_err("gtk_offload_info invalid response bss index %d\n",
2911 rsp->bss_index);
2912 return -ENOENT;
2913 }
2914
2915 if (vif_priv->rekey_data.replay_ctr != cpu_to_le64(rsp->key_replay_counter)) {
2916 replay_ctr = cpu_to_be64(rsp->key_replay_counter);
2917 vif_priv->rekey_data.replay_ctr =
2918 cpu_to_le64(rsp->key_replay_counter);
2919 ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
2920 (void *)&replay_ctr, GFP_KERNEL);
> 2921 wcn36xx_dbg(WCN36XX_DBG_HAL,
2922 "GTK replay counter increment %llu\n",
2923 rsp->key_replay_counter);
2924 }
2925
2926 wcn36xx_dbg(WCN36XX_DBG_HAL,
2927 "gtk offload info status %d last_rekey_status %d "
2928 "replay_counter %llu total_rekey_count %d gtk_rekey_count %d "
2929 "igtk_rekey_count %d bss_index %d\n",
2930 rsp->status, rsp->last_rekey_status,
2931 rsp->key_replay_counter, rsp->total_rekey_count,
2932 rsp->gtk_rekey_count, rsp->igtk_rekey_count,
2933 rsp->bss_index);
2934
2935 return 0;
2936 }
2937
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38274 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-03 3:39 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 16:13 drivers/net/wireless/ath/wcn36xx/smd.c:2921 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-05-03 3:38 kernel test robot
2022-04-23 11:32 kernel test robot
2022-04-22 8:35 kernel test robot
2022-04-21 6:44 kernel test robot
2022-04-19 23:50 kernel test robot
2022-04-18 8:51 kernel test robot
2022-03-31 20:18 kernel test robot
2021-11-14 3:42 kernel test robot
2021-08-05 8:36 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).