LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: tiwai@suse.de, perex@perex.cz, broonie@kernel.org,
	lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s
Date: Mon, 26 Jan 2015 12:56:23 +0100	[thread overview]
Message-ID: <2047908.1EOGyb8YHD@wuerfel> (raw)
In-Reply-To: <1422267511-6649-3-git-send-email-Zubair.Kakakhel@imgtec.com>

On Monday 26 January 2015 10:18:29 Zubair Lutfullah Kakakhel wrote:
> index 0000000..0e40517
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ingenic,jz4740-i2s.txt
> @@ -0,0 +1,18 @@
> +Ingenic JZ4740 I2S controller
> +
> +Required properties:
> +- compatible : "ingenic,jz4740-i2s"
> +- reg : I2S registers location and length
> +- clocks : AIC and I2S PLL clock specifiers.
> +- clock-names: "aic" and "i2s"
> +
> +Example:
> +
> +i2s: i2s@10020000 {
> +       compatible = "ingenic,jz4740-i2s";
> +       reg = <0x10020000 0x94>;
> +
> +       clocks = <&cgu JZ4740_CLK_AIC>, <&cgu JZ4740_CLK_I2SPLL>;
> +       clock-names = "aic", "i2s";
> +
> +};
> 

I would argue that the binding should mandate "dmas" property already.
The code currently does not use it, but it will need to get changed
in order to allow the dmaengine driver for this platform to be
converted. You should require only one argument for the channel ID,
so something like

	dmas = <&dma 24>, <&dma 25>;
	dma-names = "tx", "rx";

would be enough for the binding. Unfortunately that also requires
having a device node for the dma engine, but you can cheat there
and not call of_dma_controller_register() in the first step.

	Arnd

  parent reply	other threads:[~2015-01-26 11:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 10:18 [PATCH 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks Zubair Lutfullah Kakakhel
2015-01-26 10:18 ` [PATCH 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s Zubair Lutfullah Kakakhel
2015-01-26 10:35   ` Lars-Peter Clausen
2015-01-26 10:18 ` [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s Zubair Lutfullah Kakakhel
2015-01-26 10:37   ` Lars-Peter Clausen
2015-01-26 11:32     ` Zubair Lutfullah Kakakhel
2015-01-26 11:38       ` [alsa-devel] " Lars-Peter Clausen
2015-01-26 11:56   ` Arnd Bergmann [this message]
2015-01-26 10:18 ` [PATCH 3/4] sound: soc: jz4740: Add DT support to jz4740-i2s driver Zubair Lutfullah Kakakhel
2015-01-26 10:18 ` [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe Zubair Lutfullah Kakakhel
2015-01-26 10:40   ` Lars-Peter Clausen
2015-01-26 11:30     ` Zubair Lutfullah Kakakhel
2015-01-26 11:42       ` [alsa-devel] " Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2047908.1EOGyb8YHD@wuerfel \
    --to=arnd@arndb.de \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --subject='Re: [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).