LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Cai Huoqing <caihuoqing@baidu.com>,
	Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	gregkh@linuxfoundation.org, martin@kaiser.cx,
	insafonov@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove LINUX_VERSION_CODE check
Date: Tue, 17 Aug 2021 14:24:55 +0200	[thread overview]
Message-ID: <20992337-fac8-64c8-887f-ee4cd79bf391@gmail.com> (raw)
In-Reply-To: <20210817081204.2232-1-caihuoqing@baidu.com>

On 8/17/21 10:12 AM, Cai Huoqing wrote:
> no need to check linux version, depending on the latest version
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>   drivers/staging/r8188eu/core/rtw_mlme.c      |  5 ----
>   drivers/staging/r8188eu/os_dep/os_intfs.c    | 26 ++------------------
>   drivers/staging/r8188eu/os_dep/rtw_android.c |  6 -----
>   drivers/staging/r8188eu/os_dep/xmit_linux.c  |  6 -----
>   4 files changed, 2 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> index 5088b555f55d..ef9d5ad17632 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> @@ -3,7 +3,6 @@
>   
>   #define _RTW_MLME_C_
>   
> -#include <linux/version.h>
>   #include "../include/osdep_service.h"
>   #include "../include/drv_types.h"
>   #include "../include/recv_osdep.h"
> @@ -1499,11 +1498,7 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter)
>   

Hi Cai,

the LINUX_VERSION_CODE checks already have been removed in commit

027ed956b526 ("staging: r8188eu: remove kernel version depended code paths")

But I forgot to remove the <linux/version.h> includes, nicely spotted.
You can send a patch that removes them. :)

Thanks,
Michael

  reply	other threads:[~2021-08-17 12:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  8:12 Cai Huoqing
2021-08-17 12:24 ` Michael Straube [this message]
2021-08-17 17:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20992337-fac8-64c8-887f-ee4cd79bf391@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=caihuoqing@baidu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --subject='Re: [PATCH] staging: r8188eu: Remove LINUX_VERSION_CODE check' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).