From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8FDC4338F for ; Tue, 17 Aug 2021 12:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3778461029 for ; Tue, 17 Aug 2021 12:25:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239896AbhHQM0R (ORCPT ); Tue, 17 Aug 2021 08:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239755AbhHQM0O (ORCPT ); Tue, 17 Aug 2021 08:26:14 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02166C0613CF for ; Tue, 17 Aug 2021 05:25:41 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id gt38so17089133ejc.13 for ; Tue, 17 Aug 2021 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ehYfeCKaZsQiuL6rOGdqMuEfjMSHQFgZSBwxefedO90=; b=uOi0pVyKP8I+9XLD80J6lRFU/URewMGwoILyautsas/7KScjvsQ/U24ZZeS/IZe6mE bB+xh+CzSBYsE9jtPcONi6dhkOwV52vljKiPZtWrdNkv7SqSMP1FVHnR8eRMwDJLCLGJ p/v54ufwgiOe49rYEHXbp5bS5C6PdLTqUvMiCgT2jbZcwrZlMnR9cWTziTlG/Xk7VkfR IlsgeO0GJNYgK/pR3/SfGmAwYwJ+0lRGvH5ikwVpf0+5IhT1eZp86KxZYEnIDMv46UvU WfMz8DRRKfwdPCt0LsyOqWLjT4EgLnxO42HuP/WAjOJpw9dy5rQGQYdx5e7dxnUlxt2Q 9ubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ehYfeCKaZsQiuL6rOGdqMuEfjMSHQFgZSBwxefedO90=; b=Wl8ae5lNI0g0dIEHyW5yTpO9KTLe9d18Udy+8vFLEzSXqqFgzPDUfb36CwXt5EC5iC GbRJvmisVqlGornxPm9wi5lKbOaE2IG5CRVepI3wti/nuIrny7cVaUtlTjrQWEKPnnNF I2GKTbVUJ3cr5Ul5jB1FowlqB/ujrbqTSP1aF+YabHlip0PXFYrDprEGKWuFFhGURgCV oaa02LHMrKRLMDaWF8LM8kmRdbKWoNhQdLJMNgT48hjhaUECL1JSNqcbpU78B7hmq0CH XsXSC6Wd5Z5YDIFozJVMaLMWNf8gxXo/yjdd0DzWcMBuD+Ug8n5UvxY66otp+IiYUute c8XA== X-Gm-Message-State: AOAM532gMsBtuDLIUDVkM6Q0m4LkJAzOv9e7Mr7EFcTFCFbtoqEbFCQT 4DI9uYHuArvIkZsbXd7TqEYm56QDQDg= X-Google-Smtp-Source: ABdhPJz2jR99RTYzwyYyOWmwz/pDZkm5zDnz/Dr62exWVt/yY0MzHyzp/wlvaHHQ/vjLMc+OZFs4jg== X-Received: by 2002:a17:906:6d11:: with SMTP id m17mr3719942ejr.325.1629203139609; Tue, 17 Aug 2021 05:25:39 -0700 (PDT) Received: from ?IPv6:2a02:8108:96c0:3b88::687e? ([2a02:8108:96c0:3b88::687e]) by smtp.gmail.com with ESMTPSA id q18sm702041ejc.84.2021.08.17.05.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 05:25:39 -0700 (PDT) Subject: Re: [PATCH] staging: r8188eu: Remove LINUX_VERSION_CODE check To: Cai Huoqing , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, martin@kaiser.cx, insafonov@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210817081204.2232-1-caihuoqing@baidu.com> From: Michael Straube Message-ID: <20992337-fac8-64c8-887f-ee4cd79bf391@gmail.com> Date: Tue, 17 Aug 2021 14:24:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210817081204.2232-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/21 10:12 AM, Cai Huoqing wrote: > no need to check linux version, depending on the latest version > > Signed-off-by: Cai Huoqing > --- > drivers/staging/r8188eu/core/rtw_mlme.c | 5 ---- > drivers/staging/r8188eu/os_dep/os_intfs.c | 26 ++------------------ > drivers/staging/r8188eu/os_dep/rtw_android.c | 6 ----- > drivers/staging/r8188eu/os_dep/xmit_linux.c | 6 ----- > 4 files changed, 2 insertions(+), 41 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c > index 5088b555f55d..ef9d5ad17632 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c > @@ -3,7 +3,6 @@ > > #define _RTW_MLME_C_ > > -#include > #include "../include/osdep_service.h" > #include "../include/drv_types.h" > #include "../include/recv_osdep.h" > @@ -1499,11 +1498,7 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter) > Hi Cai, the LINUX_VERSION_CODE checks already have been removed in commit 027ed956b526 ("staging: r8188eu: remove kernel version depended code paths") But I forgot to remove the includes, nicely spotted. You can send a patch that removes them. :) Thanks, Michael