LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Michael Thayer <michael.thayer@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool
Date: Fri, 26 Oct 2018 16:04:45 -0300 [thread overview]
Message-ID: <211701e4ae42acd95afb24713314bce5a4c58ecf.1540580493.git.shayenneluzmoura@gmail.com> (raw)
In-Reply-To: <cover.1540580493.git.shayenneluzmoura@gmail.com>
This change was suggested by checkpath.pl. Use unsigned int with bitfield
allocate only one bit to the boolean variable.
CHECK: Avoid using bool structure members because of possible alignment
issues
Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
---
drivers/staging/vboxvideo/vbox_drv.h | 14 +++++++-------
drivers/staging/vboxvideo/vboxvideo_guest.h | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_drv.h b/drivers/staging/vboxvideo/vbox_drv.h
index 594f84272957..7d3e329a6b1c 100644
--- a/drivers/staging/vboxvideo/vbox_drv.h
+++ b/drivers/staging/vboxvideo/vbox_drv.h
@@ -81,7 +81,7 @@ struct vbox_private {
u8 __iomem *vbva_buffers;
struct gen_pool *guest_pool;
struct vbva_buf_ctx *vbva_info;
- bool any_pitch;
+ unsigned int any_pitch:1;
u32 num_crtcs;
/** Amount of available VRAM, including space used for buffers. */
u32 full_vram_size;
@@ -106,7 +106,7 @@ struct vbox_private {
* depending on whether they react to a hot-plug event after the initial
* mode query.
*/
- bool initial_mode_queried;
+ unsigned int initial_mode_queried:1;
struct work_struct hotplug_work;
u32 input_mapping_width;
u32 input_mapping_height;
@@ -114,7 +114,7 @@ struct vbox_private {
* Is user-space using an X.Org-style layout of one large frame-buffer
* encompassing all screen ones or is the fbdev console active?
*/
- bool single_framebuffer;
+ unsigned int single_framebuffer:1;
u32 cursor_width;
u32 cursor_height;
u32 cursor_hot_x;
@@ -139,17 +139,17 @@ struct vbox_connector {
struct {
u32 width;
u32 height;
- bool disconnected;
+ unsigned int disconnected:1;
} mode_hint;
};
struct vbox_crtc {
struct drm_crtc base;
- bool blanked;
- bool disconnected;
+ unsigned int blanked:1;
+ unsigned int disconnected:1;
unsigned int crtc_id;
u32 fb_offset;
- bool cursor_enabled;
+ unsigned int cursor_enabled:1;
u32 x_hint;
u32 y_hint;
};
diff --git a/drivers/staging/vboxvideo/vboxvideo_guest.h b/drivers/staging/vboxvideo/vboxvideo_guest.h
index d09da841711a..7a98fb4fb108 100644
--- a/drivers/staging/vboxvideo/vboxvideo_guest.h
+++ b/drivers/staging/vboxvideo/vboxvideo_guest.h
@@ -36,7 +36,7 @@ struct vbva_buf_ctx {
/** Length of the buffer in bytes */
u32 buffer_length;
/** Set if we wrote to the buffer faster than the host could read it */
- bool buffer_overflow;
+ unsigned int buffer_overflow:1;
/** VBVA record that we are currently preparing for the host, or NULL */
struct vbva_record *record;
/**
--
2.19.1
next prev parent reply other threads:[~2018-10-26 19:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 19:03 [RESEND PATCH 0/2] staging: vboxvideo: Remove chekpatch issues Shayenne da Luz Moura
2018-10-26 19:04 ` [RESEND PATCH 1/2] staging: vboxvideo: Change uint32_t to u32 Shayenne da Luz Moura
2018-10-28 11:02 ` Hans de Goede
2018-10-26 19:04 ` Shayenne da Luz Moura [this message]
2018-10-26 20:42 ` [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool Sasha Levin
2018-10-26 20:54 ` Julia Lawall
2018-10-27 21:59 ` Joe Perches
2018-10-28 5:41 ` Julia Lawall
2018-10-28 7:52 ` Himanshu Jha
2018-10-28 8:47 ` Julia Lawall
2018-10-28 11:20 ` Himanshu Jha
2018-10-28 11:46 ` Julia Lawall
2018-10-30 20:18 ` Shayenne Moura
2018-10-30 20:25 ` Julia Lawall
2018-10-30 20:33 ` Shayenne Moura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211701e4ae42acd95afb24713314bce5a4c58ecf.1540580493.git.shayenneluzmoura@gmail.com \
--to=shayenneluzmoura@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
--cc=outreachy-kernel@googlegroups.com \
--subject='Re: [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).