LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] LOCKDEP: minor fix for debug_show_all_locks()
@ 2008-10-27 20:03 sniper
  2008-10-28  8:29 ` Ingo Molnar
  0 siblings, 1 reply; 4+ messages in thread
From: sniper @ 2008-10-27 20:03 UTC (permalink / raw)
  To: mingo, peterz; +Cc: linux-kernel

When we failed to get tasklist_lock eventually (count equals 0),
we should only print " ignoring it.\n", and not print
" locked it.\n" needlessly.

Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index dbda475..12bf812 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3417,10 +3417,12 @@ retry:
 		}
 		printk(" ignoring it.\n");
 		unlock = 0;
+		goto print_locks;
 	}
 	if (count != 10)
 		printk(" locked it.\n");

+print_locks:
 	do_each_thread(g, p) {
 		/*
 		 * It's not reliable to print a task's held locks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-10-28  9:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-27 20:03 [PATCH] LOCKDEP: minor fix for debug_show_all_locks() sniper
2008-10-28  8:29 ` Ingo Molnar
2008-10-28  9:24   ` qinghuang feng
2008-10-28  9:31     ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).