LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Indan Zupancic" <indan@nul.nu>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "Greg Kroah-Hartman" <gregkh@suse.de>
Subject: Re: Linux 2.6.22-rc1
Date: Sun, 13 May 2007 14:44:54 +0200 (CEST)	[thread overview]
Message-ID: <2221.81.207.0.53.1179060294.squirrel@secure.samage.net> (raw)
In-Reply-To: <alpine.LFD.0.98.0705121857100.6739@woody.linux-foundation.org>

Hello,

When compiling 2.6.22-rc1 I get the following (new and interesting) warnings:

GEN     /home/indan/src/git/obj/Makefile
scripts/kconfig/conf -s arch/i386/Kconfig
drivers/macintosh/Kconfig:116:warning:
'select' used by config symbol 'PMAC_APM_EMU'
refers to undefined symbol 'SYS_SUPPORTS_APM_EMULATION'
drivers/net/Kconfig:2283:warning:
'select' used by config symbol 'UCC_GETH'
refers to undefined symbol 'UCC_FAST'
drivers/input/keyboard/Kconfig:170:warning:
'select' used by config symbol 'KEYBOARD_ATARI'
refers to undefined symbol 'ATARI_KBD_CORE'
drivers/input/mouse/Kconfig:181:warning:
'select' used by config symbol 'MOUSE_ATARI'
refers to undefined symbol 'ATARI_KBD_CORE'

And:

/home/indan/src/git/linux-2.6/drivers/base/dd.c:211:
warning: 'device_probe_drivers' defined but not used

No idea how the first warnings can show up at all when I've selected nothing
related to them, nor who to CC for it.

Added Greg to the CC list for the second warning. device_probe_drivers() is
a static function, so it seems safe to remove.

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 92428e5..b0088b0 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -207,19 +207,6 @@ static int __device_attach(struct device_driver * drv, void * data)
 	return driver_probe_device(drv, dev);
 }

-static int device_probe_drivers(void *data)
-{
-	struct device *dev = data;
-	int ret = 0;
-
-	if (dev->bus) {
-		down(&dev->sem);
-		ret = bus_for_each_drv(dev->bus, NULL, dev, __device_attach);
-		up(&dev->sem);
-	}
-	return ret;
-}
-
 /**
  *	device_attach - try to attach device to a driver.
  *	@dev:	device.



  parent reply	other threads:[~2007-05-13 12:45 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13  3:20 Linus Torvalds
2007-05-13  9:20 ` Jan Engelhardt
2007-05-17  6:55   ` Len Brown
2007-05-13  9:29 ` Linux 2.6.22-rc1, 'nother randconfig Jan Engelhardt
2007-05-13  9:47 ` [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1) Borislav Petkov
2007-05-14  8:06   ` Cornelia Huck
2007-05-13 12:44 ` Linux 2.6.22-rc1 Alessandro Suardi
2007-05-13 12:44 ` Indan Zupancic [this message]
2007-05-13 17:10 ` Antonino Ingargiola
2007-05-13 17:53   ` Linus Torvalds
2007-05-13 18:50     ` Antonino Ingargiola
2007-05-14  6:10       ` Jean Delvare
2007-05-14  8:34         ` Antonino Ingargiola
2007-05-14 12:14           ` Jean Delvare
2007-05-14 13:28             ` Antonino Ingargiola
2007-05-14 15:21               ` Jean Delvare
2007-05-14 16:04                 ` Antonino Ingargiola
2007-05-14 16:23                   ` Michal Piotrowski
2007-05-14 18:08                   ` Jean Delvare
2007-05-14 18:25                     ` Antonino Ingargiola
2007-05-14 16:30                 ` Linus Torvalds
2007-05-14 18:24                   ` Jean Delvare
2007-05-14 18:43                     ` Linus Torvalds
2007-05-14 19:28                       ` Jean Delvare
2007-05-14 19:53                         ` Jeff Garzik
2007-05-14 20:18                           ` Christoph Hellwig
2007-05-14 20:17                         ` Christoph Hellwig
2007-05-14 20:15                       ` Christoph Hellwig
2007-05-15 20:31             ` CONFIG_BREAK_MY_MACHINE was " Pavel Machek
2007-05-16 18:11               ` CONFIG_BREAK_MY_MACHINE Jean Delvare
2007-05-17  8:32                 ` CONFIG_BREAK_MY_MACHINE Hans de Goede
2007-05-17  8:47                   ` CONFIG_BREAK_MY_MACHINE Pavel Machek
2007-05-13 18:19 ` Linux 2.6.22-rc1 Tilman Schmidt
2007-05-13 23:20   ` David Miller
2007-05-13 23:32     ` Roland Dreier
2007-05-13 23:57     ` Tilman Schmidt
2007-05-14  4:37     ` Sam Ravnborg
2007-05-14  4:53       ` David Miller
2007-05-14  6:21     ` Satyam Sharma
2007-05-14 17:21   ` Jan Engelhardt
2007-05-14 17:32     ` Stefan Richter
2007-05-14 20:27       ` Jan Engelhardt
2007-05-14 18:01     ` Tilman Schmidt
2007-05-14 20:33       ` Jan Engelhardt
2007-05-14 21:40         ` Tilman Schmidt
2007-05-14 22:09           ` Stefan Richter
2007-05-15  3:02             ` Satyam Sharma
2007-05-15  8:08               ` Jan Engelhardt
2007-05-14 21:54         ` Stefan Richter
2007-05-15  2:34         ` Satyam Sharma
2007-05-15  2:42           ` Satyam Sharma
2007-05-15  6:05             ` Stefan Richter
2007-05-15  6:01           ` Stefan Richter
2007-05-15  8:16           ` Jan Engelhardt
2007-05-16  1:52             ` Satyam Sharma
2007-05-16  6:29               ` Stefan Richter
2007-05-16  9:56                 ` Satyam Sharma
2007-05-15 10:43           ` Tilman Schmidt
2007-05-16  1:39             ` Satyam Sharma
2007-05-16  9:14               ` Tilman Schmidt
2007-05-16  9:17                 ` Satyam Sharma
2007-05-15  5:35         ` Michael Gerdau
2007-05-13 20:51 ` 2.6.22-rc1: loop.c Alexey Dobriyan
2007-05-14  3:52   ` Jeremy Fitzhardinge
2007-05-13 22:53 ` Linux 2.6.22-rc1 Jeff Chua
2007-05-14  1:08 ` andrew hendry
2007-05-14  7:49 ` V4L Regression (Was: Linux 2.6.22-rc1) Robert Fitzsimons
2007-05-14 11:44 ` Linux 2.6.22-rc1, 'nother randconfig David Howells
2007-05-14 17:23   ` Jan Engelhardt
2007-05-15  9:26   ` David Howells
2007-05-15  9:40     ` Jan Engelhardt
2007-05-15  4:14 ` Linux 2.6.22-rc1 andrew hendry
2007-05-15  4:38   ` Linus Torvalds
2007-05-15  5:10     ` andrew hendry
2007-05-15 15:57       ` Linus Torvalds
2007-05-15 22:50         ` andrew hendry
2007-05-13  6:00 Jeff Chua
2007-05-13  6:13 ` Jeff Chua
2007-05-13  8:04 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2221.81.207.0.53.1179060294.squirrel@secure.samage.net \
    --to=indan@nul.nu \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Linux 2.6.22-rc1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).