From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755452AbbAZNVh (ORCPT ); Mon, 26 Jan 2015 08:21:37 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:61069 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754886AbbAZNVb (ORCPT ); Mon, 26 Jan 2015 08:21:31 -0500 From: "Rafael J. Wysocki" To: "Fu, Zhonghui" Cc: len.brown@intel.com, pavel@ucw.cz, Greg Kroah-Hartman , linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] PM/Trace: get rid of synchronous resume limit during PM trace Date: Mon, 26 Jan 2015 14:44:15 +0100 Message-ID: <2226940.FhLLx52rcO@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <54C5F3FF.6030600@linux.intel.com> References: <54C5CB77.4000109@linux.intel.com> <54C5F3FF.6030600@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, January 26, 2015 03:59:59 PM Fu, Zhonghui wrote: > > This is a incorrect patch , please ignore it. Of course it is incorrect. If it "fixes" anything for you, this means you need to reorder devices in dpm_list on the given system. > On 2015/1/26 13:07, Fu, Zhonghui wrote: > > From f9c841d1f943d81b5ab0aac7483e794a7f966296 Mon Sep 17 00:00:00 2001 > > From: Zhonghui Fu > > Date: Mon, 26 Jan 2015 11:27:08 +0800 > > Subject: [PATCH] PM/Trace: get rid of synchronous resume limit during PM trace > > > > There are some kind of dependency between devices in some > > hardware platforms. So, asynchronous resuming devices may > > hang system due to wrong resume order. As a result, should > > not fore synchronously resuming devices during tracing > > PM events. > > > > Signed-off-by: Zhonghui Fu > > --- > > drivers/base/power/main.c | 3 +-- > > include/linux/resume-trace.h | 7 ------- > > 2 files changed, 1 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > > index 9717d5f..5df148b 100644 > > --- a/drivers/base/power/main.c > > +++ b/drivers/base/power/main.c > > @@ -517,8 +517,7 @@ static int device_resume_noirq(struct device *dev, pm_message_t state, bool asyn > > > > static bool is_async(struct device *dev) > > { > > - return dev->power.async_suspend && pm_async_enabled > > - && !pm_trace_is_enabled(); > > + return dev->power.async_suspend && pm_async_enabled; > > } > > > > static void async_resume_noirq(void *data, async_cookie_t cookie) > > diff --git a/include/linux/resume-trace.h b/include/linux/resume-trace.h > > index f31db23..fd0866e 100644 > > --- a/include/linux/resume-trace.h > > +++ b/include/linux/resume-trace.h > > @@ -7,11 +7,6 @@ > > > > extern int pm_trace_enabled; > > > > -static inline int pm_trace_is_enabled(void) > > -{ > > - return pm_trace_enabled; > > -} > > - > > struct device; > > extern void set_trace_device(struct device *); > > extern void generate_resume_trace(const void *tracedata, unsigned int user); > > @@ -24,8 +19,6 @@ extern int show_trace_dev_match(char *buf, size_t size); > > > > #else > > > > -static inline int pm_trace_is_enabled(void) { return 0; } > > - > > #define TRACE_DEVICE(dev) do { } while (0) > > #define TRACE_RESUME(dev) do { } while (0) > > > > -- 1.7.1 > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.