LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paolo Valente <paolo.valente@linaro.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block <linux-block@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	linus.walleij@linaro.org, bfq-iosched@googlegroups.com,
	oleksandr@natalenko.name
Subject: Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge
Date: Sun, 6 May 2018 09:42:51 +0200	[thread overview]
Message-ID: <223CABEA-71E0-426F-A4AB-17BA8437C978@linaro.org> (raw)
In-Reply-To: <1525532191.5406.15.camel@gmx.de>



> Il giorno 05 mag 2018, alle ore 16:56, Mike Galbraith <efault@gmx.de> ha scritto:
> 
> On Sat, 2018-05-05 at 12:39 +0200, Paolo Valente wrote:
>> 
>> BTW, if you didn't run out of patience with this permanent issue yet,
>> I was thinking of two o three changes to retry to trigger your failure
>> reliably.
> 
> Sure, fire away, I'll happily give the annoying little bugger
> opportunities to show its tender belly.

I've attached a compressed patch (to avoid possible corruption from my
mailer).  I'm little confident, but no pain, no gain, right?

If possible, apply this patch on top of the fix I proposed in this
thread, just to eliminate possible further noise. Finally, the
patch content follows.

Hoping for a stroke of luck,
Paolo

diff --git a/block/bfq-mq-iosched.c b/block/bfq-mq-iosched.c
index 118f319af7c0..6662efe29b69 100644
--- a/block/bfq-mq-iosched.c
+++ b/block/bfq-mq-iosched.c
@@ -525,8 +525,13 @@ static void bfq_limit_depth(unsigned int op, struct blk_mq_alloc_data *data)
        if (unlikely(bfqd->sb_shift != bt->sb.shift))
                bfq_update_depths(bfqd, bt);
 
+#if 0
        data->shallow_depth =
                bfqd->word_depths[!!bfqd->wr_busy_queues][op_is_sync(op)];
+#else
+       data->shallow_depth = 1;
+#endif
+
 
        bfq_log(bfqd, "wr_busy %d sync %d depth %u",
                        bfqd->wr_busy_queues, op_is_sync(op),


> 
> 	-Mike
> 

  reply	other threads:[~2018-05-06  7:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 17:17 Paolo Valente
2018-05-04 19:46 ` Mike Galbraith
2018-05-05  8:19   ` Mike Galbraith
2018-05-05 10:39     ` Paolo Valente
2018-05-05 14:56       ` Mike Galbraith
2018-05-06  7:42         ` Paolo Valente [this message]
2018-05-07  2:43           ` Mike Galbraith
2018-05-07  3:23             ` Mike Galbraith
2018-05-07  9:32               ` Paolo Valente
2018-05-07  5:56           ` Mike Galbraith
2018-05-07  9:27             ` Paolo Valente
2018-05-07 10:01               ` Mike Galbraith
2018-05-07 18:03                 ` Paolo Valente
2018-05-06  7:33 ` Oleksandr Natalenko
2018-05-10 16:14 ` Bart Van Assche
2018-05-14 17:16   ` Paolo Valente
2018-05-14 17:31     ` Jens Axboe
2018-05-14 17:37       ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=223CABEA-71E0-426F-A4AB-17BA8437C978@linaro.org \
    --to=paolo.valente@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=bfq-iosched@googlegroups.com \
    --cc=broonie@kernel.org \
    --cc=efault@gmx.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH BUGFIX] block, bfq: postpone rq preparation to insert or merge' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).