LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Tedd Ho-Jeong An <tedd.an@linux.intel.com>
Cc: Mark-YW.Chen@mediatek.com,
	Johan Hedberg <johan.hedberg@gmail.com>,
	chris.lu@mediatek.com, will-cy.lee@mediatek.com,
	Sean Wang <sean.wang@mediatek.com>,
	BlueZ <linux-bluetooth@vger.kernel.org>,
	linux-mediatek@lists.infradead.org,
	open list <linux-kernel@vger.kernel.org>,
	Michael Sun <michaelfsun@google.com>,
	shawnku@google.com, jemele@google.com,
	Archie Pusaka <apusaka@google.com>,
	Miao-chen Chou <mcchou@chromium.org>
Subject: Re: [PATCH v5 1/2] Bluetooth: btusb: Record debug log for Mediatek Chip.
Date: Thu, 5 Aug 2021 15:12:48 +0200	[thread overview]
Message-ID: <22F94464-EF65-4676-AC61-1E13E22A837F@holtmann.org> (raw)
In-Reply-To: <4e9d536cb6a7cffb829f105183f2bb5bceb4122c.camel@linux.intel.com>

Hi Tedd,

> I cannot find the original patch email and CI report, however this patch throws this warning.
> 
> drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
> drivers/bluetooth/btusb.c:4033:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 4033 |   usb_disable_autosuspend(data->udev);
>      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c:4034:2: note: here
> 4034 |  case 0x05ff:  /* Firmware debug logging 1 */
>      |  ^~~~

the /* fall through */ comment is missing.

Regards

Marcel


  reply	other threads:[~2021-08-05 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210804090316.12080-1-mark-yw.chen@mediatek.com>
2021-08-04 14:48 ` Marcel Holtmann
2021-08-04 23:14   ` Tedd Ho-Jeong An
2021-08-05 13:12     ` Marcel Holtmann [this message]
     [not found] ` <20210804090316.12080-2-mark-yw.chen@mediatek.com>
2021-08-04 14:49   ` [PATCH v5 2/2] Bluetooth: btusb: Support Bluetooth Reset for Mediatek Chip(MT7921) Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22F94464-EF65-4676-AC61-1E13E22A837F@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=Mark-YW.Chen@mediatek.com \
    --cc=apusaka@google.com \
    --cc=chris.lu@mediatek.com \
    --cc=jemele@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mcchou@chromium.org \
    --cc=michaelfsun@google.com \
    --cc=sean.wang@mediatek.com \
    --cc=shawnku@google.com \
    --cc=tedd.an@linux.intel.com \
    --cc=will-cy.lee@mediatek.com \
    --subject='Re: [PATCH v5 1/2] Bluetooth: btusb: Record debug log for Mediatek Chip.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).