LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrea Reale <ar@linux.vnet.ibm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	m.bielski@virtualopensystems.com, arunks@qti.qualcomm.com,
	mark.rutland@arm.com, scott.branden@broadcom.com,
	will.deacon@arm.com, qiuxishi@huawei.com,
	catalin.marinas@arm.com, mhocko@suse.com, realean2@ie.ibm.com
Subject: [PATCH v2 4/5] mm: memory_hotplug: Add memory hotremove probe device
Date: Thu, 23 Nov 2017 11:14:52 +0000	[thread overview]
Message-ID: <22d34fe30df0fbacbfceeb47e20cb1184af73585.1511433386.git.ar@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1511433386.git.ar@linux.vnet.ibm.com>

Adding a "remove" sysfs handle that can be used to trigger
memory hotremove manually, exactly simmetrically with
what happens with the "probe" device for hot-add.

This is usueful for architecture that do not rely on
ACPI for memory hot-remove.

Signed-off-by: Andrea Reale <ar@linux.vnet.ibm.com>
Signed-off-by: Maciej Bielski <m.bielski@virtualopensystems.com>
---
 drivers/base/memory.c | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 1d60b58..8ccb67c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -530,7 +530,36 @@ memory_probe_store(struct device *dev, struct device_attribute *attr,
 }
 
 static DEVICE_ATTR(probe, S_IWUSR, NULL, memory_probe_store);
-#endif
+
+#ifdef CONFIG_MEMORY_HOTREMOVE
+static ssize_t
+memory_remove_store(struct device *dev,
+		struct device_attribute *attr, const char *buf, size_t count)
+{
+	u64 phys_addr;
+	int nid, ret;
+	unsigned long pages_per_block = PAGES_PER_SECTION * sections_per_block;
+
+	ret = kstrtoull(buf, 0, &phys_addr);
+	if (ret)
+		return ret;
+
+	if (phys_addr & ((pages_per_block << PAGE_SHIFT) - 1))
+		return -EINVAL;
+
+	nid = memory_add_physaddr_to_nid(phys_addr);
+	ret = lock_device_hotplug_sysfs();
+	if (ret)
+		return ret;
+
+	remove_memory(nid, phys_addr,
+			 MIN_MEMORY_BLOCK_SIZE * sections_per_block);
+	unlock_device_hotplug();
+	return count;
+}
+static DEVICE_ATTR(remove, S_IWUSR, NULL, memory_remove_store);
+#endif /* CONFIG_MEMORY_HOTREMOVE */
+#endif /* CONFIG_ARCH_MEMORY_PROBE */
 
 #ifdef CONFIG_MEMORY_FAILURE
 /*
@@ -790,6 +819,9 @@ bool is_memblock_offlined(struct memory_block *mem)
 static struct attribute *memory_root_attrs[] = {
 #ifdef CONFIG_ARCH_MEMORY_PROBE
 	&dev_attr_probe.attr,
+#ifdef CONFIG_MEMORY_HOTREMOVE
+	&dev_attr_remove.attr,
+#endif
 #endif
 
 #ifdef CONFIG_MEMORY_FAILURE
-- 
2.7.4

  parent reply	other threads:[~2017-11-23 11:15 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 11:13 [PATCH v2 0/5] Memory hotplug support for arm64 - complete patchset v2 Andrea Reale
2017-11-23 11:13 ` [PATCH v2 1/5] mm: memory_hotplug: Memory hotplug (add) support for arm64 Maciej Bielski
2017-11-24  5:55   ` Arun KS
2017-11-24  9:42     ` Andrea Reale
2017-11-24 10:53       ` Maciej Bielski
2017-11-26  6:58         ` Arun KS
2017-11-27 15:19   ` Robin Murphy
2017-11-27 16:39     ` Maciej Bielski
2017-11-27 17:11       ` Andrea Reale
2017-11-23 11:14 ` [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove Andrea Reale
2017-11-23 22:18   ` Rafael J. Wysocki
2017-11-24 14:39   ` Rafael J. Wysocki
2017-11-24 14:49     ` Andrea Reale
2017-11-24 15:43       ` Michal Hocko
2017-11-24 15:54         ` Andrea Reale
2017-11-24 18:17           ` Michal Hocko
2017-11-29  1:20             ` joeyli
2017-11-30  9:47               ` Michal Hocko
2017-11-27 15:20           ` Robin Murphy
2017-11-27 17:44             ` Andrea Reale
2017-11-29  0:49   ` joeyli
2017-11-29  1:52     ` joeyli
2017-12-04 11:28       ` Andrea Reale
2017-12-04 14:05         ` Rafael J. Wysocki
2017-11-23 11:14 ` [PATCH v2 3/5] mm: memory_hotplug: memblock to track partially removed vmemmap mem Andrea Reale
2017-11-27 15:20   ` Robin Murphy
2017-11-27 17:38     ` Andrea Reale
2017-11-30 14:51   ` Michal Hocko
2017-12-04 11:49     ` Andrea Reale
2017-12-04 12:32       ` Michal Hocko
2017-12-04 12:42         ` Andrea Reale
2017-12-04 12:48           ` Michal Hocko
2017-11-23 11:14 ` Andrea Reale [this message]
2017-11-24 10:35   ` [PATCH v2 4/5] mm: memory_hotplug: Add memory hotremove probe device zhong jiang
2017-11-24 10:44     ` Andrea Reale
2017-11-24 12:17       ` zhong jiang
2017-11-24 14:29         ` Andrea Reale
2017-12-04 17:50           ` Reza Arbab
2017-11-27 15:33   ` Robin Murphy
2017-11-27 17:14     ` Andrea Reale
2017-11-30 14:49   ` Michal Hocko
2017-12-04 11:51     ` Andrea Reale
2017-12-04 12:33       ` Michal Hocko
2017-12-04 12:44         ` Andrea Reale
2017-11-23 11:15 ` [PATCH v2 5/5] mm: memory-hotplug: Add memory hot remove support for arm64 Andrea Reale
2017-11-23 16:02 ` [PATCH v2 0/5] Memory hotplug support for arm64 - complete patchset v2 Michal Hocko
2017-11-23 17:33   ` Andrea Reale
2017-11-30 14:57     ` Michal Hocko
2017-12-04 11:34       ` Andrea Reale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22d34fe30df0fbacbfceeb47e20cb1184af73585.1511433386.git.ar@linux.vnet.ibm.com \
    --to=ar@linux.vnet.ibm.com \
    --cc=arunks@qti.qualcomm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.bielski@virtualopensystems.com \
    --cc=mark.rutland@arm.com \
    --cc=mhocko@suse.com \
    --cc=qiuxishi@huawei.com \
    --cc=realean2@ie.ibm.com \
    --cc=scott.branden@broadcom.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).