LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [RFC 00/13] arm64: allwinner: Add A64 DE2 pipeline support
Date: Fri, 27 Apr 2018 00:13:12 +0200	[thread overview]
Message-ID: <23105300.vUZDKFF453@jernej-laptop> (raw)
In-Reply-To: <CAMty3ZDfiqKMpesTg-oaCRNJ4-gBs48vY-TXgRFJkLB7gjKaYQ@mail.gmail.com>

Hi,

Dne četrtek, 26. april 2018 ob 15:26:49 CEST je Jagan Teki napisal(a):
> On Wed, Apr 25, 2018 at 11:29 PM, Jernej Škrabec
> 
> <jernej.skrabec@siol.net> wrote:
> > Hi,
> > 
> > Dne sreda, 25. april 2018 ob 12:34:09 CEST je Jagan Teki napisal(a):
> >> On Tue, Apr 24, 2018 at 9:02 PM, Jernej Škrabec <jernej.skrabec@siol.net>
> > 
> > wrote:
> >> > Hi,
> >> > 
> >> > Dne torek, 24. april 2018 ob 15:34:12 CEST je Jagan Teki napisal(a):
> >> >> Allwinner A64 has display engine pipeline like other Allwinner SOC's
> >> >> A83T/H3/H5.
> >> >> 
> >> >> A64 DE2 behaviour similar to Allwinner A83T where mixer0, connected to
> >> >> tcon0 with RGB, LVDS MIPI-DSI and mixer1, connected to tcon1 with
> >> >> HDMI.
> >> >> This series merely concentrated on HDMI pipeline and rest will add
> >> >> eventually.
> >> >> 
> >> >> patch 1: dt-bindings for a64 DE2 CCU
> >> >> 
> >> >> patch 2: a64 DE2 CCU node addition
> >> >> 
> >> >> patch 3: dt-bindings for a64 DE2 pipeline
> >> >> 
> >> >> patch 4 - 5: dt-bindings for a64 mixer0 and tcon-lcd
> >> >> 
> >> >> patch 6: a64 DE2 pipeline node addition
> >> >> 
> >> >> patch 7 - 8: dt-bindings for a64 HDMI and HDMI PHY
> >> >> 
> >> >> patch 9: a64 HDMI nodes addition
> >> >> 
> >> >> patch 10 - 11: dt-bindings for a64 mixer1 and tcon-tv
> >> >> 
> >> >> patch 12: a64 HDMI pipeline
> >> >> 
> >> >> patch 13: enable HDMI out on bananpi-m64
> >> >> 
> >> >> Tested HDMI on bananapi-m64 (along with DE2 SRAM C changes from [1]
> >> >> thread), able to detect the HDMI but, no penguins on screen.
> >> >> 
> >> >> Request for any suggestions.
> >> > 
> >> > You are mising sunxi-ng clock patches. PLL_VIDEO0 and PLL_VIDEO1 need
> >> > fixes by setting minimum stable frequency. Please note that datasheet
> >> > may
> >> > have wrong information. That was obvious in H3 case and I had to check
> >> > minimum stable PLL_VIDEO frequency in BSP driver.
> >> 
> >> Can you point me the clock patches?
> > 
> > Here is my A64 HDMI wip repo, which includes my clock changes:
> > https://github.com/jernejsk/linux-1/tree/a64_hdmi_wip
> > 
> > At some point HDMI output worked ok, I'm not sure in what state I left the
> > code.
> 
> Jernej, thanks for the regulator change in another mail, yes
> bananapi-m64 has HVCC regulator for HDMI glue, with this I'm able to
> see penguins on screen.

Ok, great.

> 
> >> I've phadled only CLK_PLL_VIDEO0
> >> on hdmi_phy So we need CLK_PLL_VIDEO1 as fourth clock?
> > 
> > I'm not sure what is the best way. I guess some research is needed. There
> > is even the possibility that one bit (SUN8I_HDMI_PHY_PLL_CFG1_CKIN_SEL)
> > in hdmi phy needs to be toggled depending on which clock is selected as
> > HDMI source. I never finished my research since I'm waiting to SRAM C
> > claiming patches.
> > 
> > At the end, HDMI driver should be tested by both, PLL_VIDEO0 and
> > PLL_VIDEO1 as a HDMI clock source, otherwise there is no guarantee that
> > we got binding right. A83T, H3 and H5 has only one possible HDMI parent
> > clock, so it was much easier in this regard.
> 
> From Figure 3-3.Module Clock Diagram of
> Allwinner_A64_User_Manual_V1.1.pdf clearly shows PLL_VIDEO1 is
> connected TCON1 which intern used by HDMI. I've verified both
> PLL_VIDEO0 and 1 both seems working. I'm thinking we can go for
> PLL_VIDEO1 as per datasheet, any suggestions?
> 
> Jagan.

Actually, same diagram also shows that PLL_VIDEO0 can be connected to TCON1/
HDMI. Since DT descibes HW, probably both phandles should be specified and 
driver should decide some way which one to select. Additionally, HDMI 
controller and HDMI PHY should use same PLL at the same time. If nothing is 
done, PLL_VIDEO0 will always be used, which might interfere in dual monitor 
setup.

Best regards,
Jernej

      reply	other threads:[~2018-04-26 22:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 13:34 Jagan Teki
2018-04-24 13:34 ` [RFC 01/13] dt-bindings: clock: Add compatible for A64 DE2 CCU Jagan Teki
2018-04-24 13:34 ` [RFC 02/13] arm64: dts: allwinner: a64: Add " Jagan Teki
2018-04-24 13:34 ` [RFC 03/13] bindings: display: Add compatible for A64 DE2 pipeline Jagan Teki
2018-04-24 13:37   ` Chen-Yu Tsai
2018-04-24 13:34 ` [RFC 04/13] bindings: display: Add compatible for A64 Mixer0 Jagan Teki
2018-04-24 13:34 ` [RFC 05/13] bindings: display: Add compatible for A64 tcon-lcd Jagan Teki
2018-04-24 13:34 ` [RFC 06/13] arm64: dts: allwinner: a64: Add DE2 pipeline Jagan Teki
2018-04-24 13:34 ` [RFC 07/13] bindings: display: Add compatible for A64 HDMI Jagan Teki
2018-04-24 13:34 ` [RFC 08/13] bindings: display: Add compatible for A64 HDMI PHY Jagan Teki
2018-04-24 13:34 ` [RFC 09/13] arm64: dts: allwinner: a64: Add HDMI support Jagan Teki
2018-04-24 15:27   ` Jernej Škrabec
2018-04-24 13:34 ` [RFC 10/13] bindings: display: Add compatible for A64 Mixer1 Jagan Teki
2018-04-24 13:34 ` [RFC 11/13] bindings: display: Add compatible for A64 tcon-tv Jagan Teki
2018-04-24 13:34 ` [RFC 12/13] arm64: dts: allwinner: a64: Add HDMI pipeline Jagan Teki
2018-04-24 13:34 ` [RFC 13/13] arm64: dts: allwinner: a64: bananapi-m64: Enable HDMI output Jagan Teki
2018-04-24 14:08 ` [RFC 00/13] arm64: allwinner: Add A64 DE2 pipeline support Maxime Ripard
2018-04-25 12:59   ` Jagan Teki
2018-04-25 13:55     ` Maxime Ripard
2018-04-25 18:06       ` Jernej Škrabec
2018-04-24 15:32 ` Jernej Škrabec
2018-04-25 10:34   ` Jagan Teki
2018-04-25 17:59     ` Jernej Škrabec
2018-04-26 13:26       ` Jagan Teki
2018-04-26 22:13         ` Jernej Škrabec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23105300.vUZDKFF453@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=michael@amarulasolutions.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=will.deacon@arm.com \
    --subject='Re: [RFC 00/13] arm64: allwinner: Add A64 DE2 pipeline support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).