LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
	David Miller <davem@davemloft.net>,
	viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: cmpxchg() in kernel/workqueue.c breaks things
Date: Thu, 07 Dec 2006 11:46:24 +0000	[thread overview]
Message-ID: <23292.1165491984@redhat.com> (raw)
In-Reply-To: <20061207032817.e9e587bd.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:

> I don't see why the 2.6.19 logic needed changing.
> 
> a) Nobody should be freeing the work_struct itself without running
>    flush_scheduled_work() and
> 
> b) even if the work_struct _did_ get freed, the callback function won't
>    care, because there's nothing in that work_struct which it's interested
>    in.

Erm...  Did you mean that in reply to my suggestion that we don't need to use
cmpxchg()?

We might want to avoid cmpxchg() because it isn't available on all platforms
under all circumstances, and besides I'm not sure it's actually necessary.

David

  parent reply	other threads:[~2006-12-07 11:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07  8:09 David Miller
2006-12-07  8:23 ` Al Viro
2006-12-07 11:03 ` David Howells
2006-12-07 11:28   ` Andrew Morton
2006-12-07 11:46   ` David Howells [this message]
2006-12-07 16:35     ` Andrew Morton
2006-12-07 13:24 ` David Howells
2006-12-07 14:53 ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23292.1165491984@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: cmpxchg() in kernel/workqueue.c breaks things' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).