LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "guohanjun@huawei.com" <guohanjun@huawei.com>,
	"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Olof Johansson <olof@lixom.net>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>,
	Sudeep Holla <Sudeep.Holla@arm.com>,
	"jcm@redhat.com" <jcm@redhat.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Mark Brown <broonie@kernel.org>, Robert Richter <rric@kernel.org>,
	Timur Tabi <timur@codeaurora.org>,
	Ashwin Chaugule <ashwinc@codeaurora.org>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
	Tomasz Nowicki <tomasz.nowicki@linaro.org>,
	Zhangdianfang <zhangdianfang@huawei.com>
Subject: Re: [update][PATCH v10 06/21] ACPI / sleep: Introduce CONFIG_ACPI_GENERIC_SLEEP
Date: Tue, 17 Mar 2015 15:30:04 +0100	[thread overview]
Message-ID: <2398042.a98hWjBeFo@vostro.rjw.lan> (raw)
In-Reply-To: <20150317123536.GB14984@red-moon>

On Tuesday, March 17, 2015 12:35:36 PM Lorenzo Pieralisi wrote:
> On Tue, Mar 17, 2015 at 03:23:11AM +0000, Rafael J. Wysocki wrote:
> 
> [...]
> 
> > > Do you mean remove CONFIG_ACPI_GENERIC_SLEEP and
> > > 
> > > +acpi-$(CONFIG_ACPI_SLEEP) += sleep.o
> > > 
> > > as well (also need to remove duplicate #ifdef CONFIG_ACPI_SLEEP in sleep.c if
> > > we doing so)?
> > 
> > Well, almost.  There is one problem with that, becuase sleep.c contains code
> > outside of the ACPI_SLEEP-dependent blocks.  That code is used for powering
> > off ACPI platforms.
> > 
> > I guess you don't want that code on ARM too, right?
> > 
> > Perhaps we can use ACPI_REDUCED_HARDWARE_ONLY for that?  ARM64 will be the
> > only arch setting it at least for the time being, is that correct?
> 
> HW reduced only platforms are still required to support sleep
> states that on arm64 are totally meaningless at present, so I do
> not think ACPI_REDUCED_HARDWARE_ONLY will cut it.
> 
> Factoring out power_off methods from sleep.c ? I know, it is not nicer
> since you split the S-states management in multiple files.
> 
> Side note: is the acpi_suspend() function in sleep.c used in the kernel ?

No, it isn't.  I've just sent a patch to drop it.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      parent reply	other threads:[~2015-03-17 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  8:14 Hanjun Guo
2015-03-13 21:49 ` Rafael J. Wysocki
2015-03-16 12:14   ` Hanjun Guo
2015-03-16 23:15     ` Rafael J. Wysocki
2015-03-17  1:08       ` Hanjun Guo
2015-03-17  2:28         ` Rafael J. Wysocki
2015-03-17  2:36           ` Hanjun Guo
2015-03-17  3:23             ` Rafael J. Wysocki
2015-03-17  4:10               ` Hanjun Guo
2015-03-17  5:59                 ` Jon Masters
2015-03-17  6:31                   ` Hanjun Guo
2015-03-17 14:33                 ` Rafael J. Wysocki
2015-03-18  1:56                   ` Hanjun Guo
2015-03-17 12:35               ` Lorenzo Pieralisi
     [not found]                 ` <CAGHbJ3DhUB688K7ooT7ai=2QjRp7S+_E_Y+a+GupeTvjR5omMg@mail.gmail.com>
2015-03-17 14:29                   ` [PATCH] ACPI / sleep: Drop acpi_suspend() which is not used Rafael J. Wysocki
2015-03-17 14:24                     ` Lorenzo Pieralisi
2015-03-18  1:17                     ` Hanjun Guo
2015-03-17 14:30                 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2398042.a98hWjBeFo@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=Catalin.Marinas@arm.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=ashwinc@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=graeme.gregory@linaro.org \
    --cc=grant.likely@linaro.org \
    --cc=guohanjun@huawei.com \
    --cc=hanjun.guo@linaro.org \
    --cc=jcm@redhat.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=olof@lixom.net \
    --cc=rric@kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=timur@codeaurora.org \
    --cc=tomasz.nowicki@linaro.org \
    --cc=zhangdianfang@huawei.com \
    --subject='Re: [update][PATCH v10 06/21] ACPI / sleep: Introduce CONFIG_ACPI_GENERIC_SLEEP' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).