LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: wangyangbo <wangyangbo@uniontech.com>
Cc: asml.silence@gmail.com, io-uring@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/01] io_uring: Add register support to other PAGE_SIZE
Date: Wed, 18 Aug 2021 07:30:42 -0600	[thread overview]
Message-ID: <24d10cda-445e-10f3-d249-dac254e199e0@kernel.dk> (raw)
In-Reply-To: <20210818055613.1655-1-wangyangbo@uniontech.com>

On 8/17/21 11:56 PM, wangyangbo wrote:
> Define rsrc table shift from PAGE_SHIFT

This really needs a lot better explanation. A good commit message
explains "why" a change is done, this one doesn't have anything really.
It briefly tells you "what" is being done, but no reasoning for why.

-- 
Jens Axboe


       reply	other threads:[~2021-08-18 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210818055613.1655-1-wangyangbo@uniontech.com>
2021-08-18 13:30 ` Jens Axboe [this message]
2021-08-19  5:56   ` [PATCH 1/1] " wangyangbo
2021-08-19 15:54     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24d10cda-445e-10f3-d249-dac254e199e0@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangyangbo@uniontech.com \
    --subject='Re: [PATCH 01/01] io_uring: Add register support to other PAGE_SIZE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).