LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org,
linux-mm@kvack.org
Cc: kwolf@redhat.com, haozhong.zhang@intel.com, jack@suse.cz,
xiaoguangrong.eric@gmail.com, riel@surriel.com,
niteshnarayanlal@hotmail.com, david@redhat.com,
ross.zwisler@intel.com, lcapitulino@redhat.com,
hch@infradead.org, mst@redhat.com, stefanha@redhat.com,
imammedo@redhat.com, marcel@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, nilal@redhat.com
Subject: Re: [Qemu-devel] [RFC v2] qemu: Add virtio pmem device
Date: Wed, 25 Apr 2018 09:25:37 -0500 [thread overview]
Message-ID: <25f3e433-cfa6-4a62-ba7f-47aef1119dfc@redhat.com> (raw)
In-Reply-To: <20180425112415.12327-4-pagupta@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 2305 bytes --]
On 04/25/2018 06:24 AM, Pankaj Gupta wrote:
> This patch adds virtio-pmem Qemu device.
>
> This device presents memory address range
> information to guest which is backed by file
> backend type. It acts like persistent memory
> device for KVM guest. Guest can perform read
> and persistent write operations on this memory
> range with the help of DAX capable filesystem.
>
> Persistent guest writes are assured with the
> help of virtio based flushing interface. When
> guest userspace space performs fsync on file
> fd on pmem device, a flush command is send to
> Qemu over VIRTIO and host side flush/sync is
> done on backing image file.
>
> This PV device code is dependent and tested
> with 'David Hildenbrand's ' patchset[1] to
> map non-PCDIMM devices to guest address space.
This sentence doesn't belong in git history. It is better to put
information like this...
> There is still upstream discussion on using
> among PCI bar vs memory device, will update
> as per concensus.
s/concensus/consensus/
>
> [1] https://marc.info/?l=qemu-devel&m=152450249319168&w=2
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
...here, where it is part of the email, but not picked up by 'git am'.
> +++ b/qapi/misc.json
> @@ -2871,6 +2871,29 @@
> }
> }
>
> +##
> +# @VirtioPMemDeviceInfo:
> +#
> +# VirtioPMem state information
> +#
> +# @id: device's ID
> +#
> +# @start: physical address, where device is mapped
> +#
> +# @size: size of memory that the device provides
> +#
> +# @memdev: memory backend linked with device
> +#
> +# Since: 2.13
> +##
> +{ 'struct': 'VirtioPMemDeviceInfo',
> + 'data': { '*id': 'str',
> + 'start': 'size',
> + 'size': 'size',
TAB damage.
> + 'memdev': 'str'
> + }
> +}
> +
> ##
> # @MemoryDeviceInfo:
> #
> @@ -2880,7 +2903,8 @@
> ##
> { 'union': 'MemoryDeviceInfo',
> 'data': { 'dimm': 'PCDIMMDeviceInfo',
> - 'nvdimm': 'PCDIMMDeviceInfo'
> + 'nvdimm': 'PCDIMMDeviceInfo',
> + 'virtio-pmem': 'VirtioPMemDeviceInfo'
> }
> }
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-04-25 14:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:24 [RFC v2 0/2] kvm "fake DAX" device flushing Pankaj Gupta
2018-04-25 11:24 ` [RFC v2 1/2] virtio: add pmem driver Pankaj Gupta
2018-04-25 14:21 ` Dan Williams
2018-04-25 14:43 ` Dan Williams
2018-04-26 12:27 ` Jeff Moyer
2018-04-26 17:15 ` [Qemu-devel] " Pankaj Gupta
2018-04-26 17:24 ` Jeff Moyer
2018-04-25 14:52 ` Michael S. Tsirkin
2018-04-25 15:11 ` [Qemu-devel] " Pankaj Gupta
2018-04-26 13:12 ` Stefan Hajnoczi
2018-04-26 15:44 ` Pankaj Gupta
2018-04-27 13:31 ` Stefan Hajnoczi
2018-04-28 10:48 ` Pankaj Gupta
2018-04-25 11:24 ` [RFC v2 2/2] pmem: device flush over VIRTIO Pankaj Gupta
2018-04-25 14:23 ` Dan Williams
2018-04-25 14:47 ` Pankaj Gupta
2018-04-26 13:15 ` Stefan Hajnoczi
2018-04-26 16:40 ` Pankaj Gupta
2018-04-26 16:57 ` Dan Williams
2018-04-26 17:13 ` Pankaj Gupta
2018-04-25 11:24 ` [RFC v2] qemu: Add virtio pmem device Pankaj Gupta
2018-04-25 11:35 ` [Qemu-devel] " no-reply
2018-04-25 11:58 ` Pankaj Gupta
2018-04-25 14:23 ` Eric Blake
2018-04-25 14:51 ` Pankaj Gupta
2018-04-25 11:46 ` no-reply
2018-04-25 14:25 ` Eric Blake [this message]
2018-04-25 14:55 ` Pankaj Gupta
2018-04-26 13:24 ` Stefan Hajnoczi
2018-04-26 16:43 ` [Qemu-devel] " Pankaj Gupta
2018-06-01 12:24 ` [Qemu-devel] [RFC v2 0/2] kvm "fake DAX" device flushing Igor Mammedov
2018-06-04 5:56 ` Pankaj Gupta
2018-06-04 9:55 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f3e433-cfa6-4a62-ba7f-47aef1119dfc@redhat.com \
--to=eblake@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=niteshnarayanlal@hotmail.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=ross.zwisler@intel.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--subject='Re: [Qemu-devel] [RFC v2] qemu: Add virtio pmem device' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).