LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Mike Galbraith <efault@gmx.de>,
	Frederik Himpe <fhimpe@telenet.be>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.24 regression: pan hanging unkilleable and un-straceable
Date: Thu, 24 Jan 2008 00:30:11 -0500	[thread overview]
Message-ID: <27437.1201152611@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 22 Jan 2008 16:25:58 +1100." <200801221625.58615.nickpiggin@yahoo.com.au>

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Tue, 22 Jan 2008 16:25:58 +1100, Nick Piggin said:
>
> Index: linux-2.6/kernel/sched.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched.c
> +++ linux-2.6/kernel/sched.c
> @@ -4920,8 +4920,7 @@ static void show_task(struct task_struct
>  	printk(KERN_CONT "%5lu %5d %6d\n", free,
>  		task_pid_nr(p), task_pid_nr(p->real_parent));
>  
> -	if (state != TASK_RUNNING)
> -		show_stack(p, NULL);
> +	show_stack(p, NULL);
>  }

Maybe something like this would be better?

	if (state == TASK_RUNNING)
		printk("running task, stack trace may be inaccurate\n");
	show_stack(p, NULL);

Just a thought....

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  parent reply	other threads:[~2008-01-24  5:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 20:58 2.6.24 regression: pan hanging unkilleable and un-straceable Frederik Himpe
2008-01-22  0:05 ` Nick Piggin
2008-01-22  5:03   ` Mike Galbraith
2008-01-22  5:25     ` Nick Piggin
2008-01-22  5:47       ` Mike Galbraith
2008-02-04 14:49         ` Mike Galbraith
2008-02-04 23:02           ` Nick Piggin
2008-01-22 10:38       ` Ingo Molnar
2008-01-24  5:30       ` Valdis.Kletnieks [this message]
2008-01-26 13:29       ` Frederik Himpe
2008-01-26 13:46         ` Nick Piggin
2008-01-26 14:27           ` Pascal Terjan
2008-01-28  1:49             ` Nick Piggin
2008-01-28  1:46         ` Nick Piggin
2008-01-28 18:05           ` Frederik Himpe
2008-01-31 22:45           ` Frederik Himpe
2008-02-02  0:53             ` Nick Piggin
2008-01-22 10:37   ` Ingo Molnar
2008-01-22 23:00     ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27437.1201152611@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=efault@gmx.de \
    --cc=fhimpe@telenet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).