LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ATA RAID breaks modular IDE compile
@ 2001-10-09  5:59 Richard Gooch
  2001-10-09  6:15 ` Keith Owens
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Gooch @ 2001-10-09  5:59 UTC (permalink / raw)
  To: torvalds, arjanv, andre; +Cc: linux-kernel

  Hi, all. In 2.4.11-pre6, the ATA RAID code breaks compiling IDE as a
module: I get duplicate "init_module" symbols. I don't even have
ATA RAID enabled!

I've appended a (crude) patch for drivers/ide/Makefile that fixed the
immediate problem for me. Perhaps this should be applied in order to
encourage a better fix to be submitted promptly ;-)

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

--- Makefile~	Mon Oct  8 23:07:43 2001
+++ Makefile	Mon Oct  8 23:48:30 2001
@@ -10,7 +10,7 @@
 
 O_TARGET := idedriver.o
 
-export-objs		:= ide.o ide-features.o ataraid.o
+export-objs		:= ide.o ide-features.o #ataraid.o
 list-multi		:= ide-mod.o ide-probe-mod.o
 
 obj-y		:=

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ATA RAID breaks modular IDE compile 
  2001-10-09  5:59 [PATCH] ATA RAID breaks modular IDE compile Richard Gooch
@ 2001-10-09  6:15 ` Keith Owens
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Owens @ 2001-10-09  6:15 UTC (permalink / raw)
  To: Richard Gooch; +Cc: torvalds, arjanv, andre, linux-kernel

On Mon, 8 Oct 2001 23:59:39 -0600, 
Richard Gooch <rgooch@ras.ucalgary.ca> wrote:
>  Hi, all. In 2.4.11-pre6, the ATA RAID code breaks compiling IDE as a
>module: I get duplicate "init_module" symbols. I don't even have
>ATA RAID enabled!

Yeuch!  Who defined ide-mod-objs in terms of $(export-objs) and why?
Fix against 2.4.11-pre6.

Index: 11-pre6.1/drivers/ide/Makefile
--- 11-pre6.1/drivers/ide/Makefile Tue, 09 Oct 2001 11:09:32 +1000 kaos (linux-2.4/E/b/44_Makefile 1.1.2.3.1.1 644)
+++ 11-pre6.1(w)/drivers/ide/Makefile Tue, 09 Oct 2001 16:13:01 +1000 kaos (linux-2.4/E/b/44_Makefile 1.1.2.3.1.1 644)
@@ -75,7 +75,7 @@ obj-$(CONFIG_BLK_DEV_ATARAID_HPT)	+= hpt
 
 ide-obj-$(CONFIG_PROC_FS)		+= ide-proc.o
 
-ide-mod-objs		:= $(export-objs) $(ide-obj-y)
+ide-mod-objs		:= ide.o ide-features.o $(ide-obj-y)
 ide-probe-mod-objs	:= ide-probe.o ide-geometry.o
 
 include $(TOPDIR)/Rules.make


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-10-09  6:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-09  5:59 [PATCH] ATA RAID breaks modular IDE compile Richard Gooch
2001-10-09  6:15 ` Keith Owens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).