LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Weiny, Ira" <ira.weiny@intel.com>
To: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, jackm <jackm@dev.mellanox.co.il>
Cc: "Håkon Bugge" <haakon.bugge@oracle.com>,
	"Hiatt, Don" <don.hiatt@intel.com>,
	"Dasaratharaman Chandramouli"
	<dasaratharaman.chandramouli@intel.com>,
	"Hefty, Sean" <sean.hefty@intel.com>,
	"OFED mailing list" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] IB/core: Make ib_mad_client_id atomic
Date: Mon, 30 Apr 2018 17:49:34 +0000	[thread overview]
Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E67DF88D8@CRSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <1525108249.11756.93.camel@redhat.com>

Looks fine to me.

> -----Original Message-----
> From: Doug Ledford [mailto:dledford@redhat.com]
> Sent: Monday, April 30, 2018 10:11 AM
> To: Jason Gunthorpe <jgg@ziepe.ca>; jackm <jackm@dev.mellanox.co.il>
> Cc: Håkon Bugge <haakon.bugge@oracle.com>; Hiatt, Don
> <don.hiatt@intel.com>; Dasaratharaman Chandramouli
> <dasaratharaman.chandramouli@intel.com>; Weiny, Ira <ira.weiny@intel.com>;
> Hefty, Sean <sean.hefty@intel.com>; OFED mailing list <linux-
> rdma@vger.kernel.org>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] IB/core: Make ib_mad_client_id atomic
> 
> On Mon, 2018-04-30 at 08:49 -0600, Jason Gunthorpe wrote:
> > On Mon, Apr 23, 2018 at 10:16:18PM +0300, jackm wrote:
> >
> > > > > TIDs need to be globally unique on the entire machine.
> > > Jason, that is not exactly correct.
> >
> > The expecation for /dev/umad users is that they all receive locally
> > unique TID prefixes. The kernel may be OK to keep things port-specific
> > but it is slightly breaking the API we are presenting to userspace to
> > allow them to alias..
> >
> > Jason
> 
> Would people be happier with this commit message then:
> 
> IB/core: Make ib_mad_client_id atomic
> 
> Currently, the kernel protects access to the agent ID allocator on a per port basis
> using a spinlock, so it is impossible for two apps/threads on the same port to get
> the same TID, but it is entirely possible for two threads on different ports to end
> up with the same TID.
> 
> As this can be confusing (regardless of it being legal according to the IB Spec 1.3,
> C13-18.1.1, in section 13.4.6.4 - TransactionID usage), and as the rdma-core user
> space API for /dev/umad devices implies unique TIDs even across ports, make
> the TID an atomic type so that no two allocations, regardless of port number, will
> be the same.
> 
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> Reviewed-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
> 
> 
> --
> Doug Ledford <dledford@redhat.com>
>     GPG KeyID: B826A3330E572FDD
>     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

  reply	other threads:[~2018-04-30 17:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 14:24 Håkon Bugge
2018-04-18 18:51 ` Weiny, Ira
2018-04-19  2:59 ` Yanjun Zhu
2018-04-20  3:55 ` Doug Ledford
2018-04-20 15:34   ` Jason Gunthorpe
2018-04-23 14:19     ` Håkon Bugge
2018-04-23 19:16       ` jackm
2018-04-26 16:06         ` Håkon Bugge
2018-04-26 18:32           ` jackm
     [not found]             ` <9fdd3ec4-ee91-5442-e753-25d2ecd27ea9@xsintricity.com>
     [not found]               ` <A58D5192-06E7-46A3-869C-273E9A2BC128@oracle.com>
2018-04-27 19:08                 ` Doug Ledford
2018-04-30 11:50                   ` Håkon Bugge
2018-04-30 14:49         ` Jason Gunthorpe
2018-04-30 17:10           ` Doug Ledford
2018-04-30 17:49             ` Weiny, Ira [this message]
2018-04-30 23:01             ` Jason Gunthorpe
2018-05-01  4:38             ` jackm
2018-05-01  6:40               ` Håkon Bugge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2807E5FD2F6FDA4886F6618EAC48510E67DF88D8@CRSMSX101.amr.corp.intel.com \
    --to=ira.weiny@intel.com \
    --cc=dasaratharaman.chandramouli@intel.com \
    --cc=dledford@redhat.com \
    --cc=don.hiatt@intel.com \
    --cc=haakon.bugge@oracle.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --subject='RE: [PATCH] IB/core: Make ib_mad_client_id atomic' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).