LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Brian Pomerantz <bapper@piratehaven.org>,
	viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
	Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH] fix page leak during core dump
Date: Sat, 31 Mar 2007 13:59:45 +0100	[thread overview]
Message-ID: <2879.1175345985@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703310005350.32047@blonde.wat.veritas.com>

Hugh Dickins <hugh@veritas.com> wrote:

> No, I think that's wrong: whereas the binfmt_elf one did its
> page_cache_release down below at the bottom of the block, this
> version does it in each subblock,

All but the first, which is why there's not a common one post if-complex.

> so there you're removing the dump_seek success one.  Can't we preserve that
> beauteous macro here and just do...
> ...
> -				DUMP_SEEK(file->f_pos + PAGE_SIZE);
>  				page_cache_release(page);
> +				DUMP_SEEK(file->f_pos + PAGE_SIZE);

Actually, that works just as well, I think.  I like it better than my
suggestion (see email in response to Andrew).

David

  parent reply	other threads:[~2007-03-31 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-29 20:39 Brian Pomerantz
2007-03-30 20:43 ` Andrew Morton
2007-03-30 22:01   ` Hugh Dickins
2007-03-30 22:13     ` Andrew Morton
2007-03-30 23:06       ` Hugh Dickins
2007-03-31 12:59       ` David Howells [this message]
2007-03-31 12:57     ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2879.1175345985@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bapper@piratehaven.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH] fix page leak during core dump' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).