LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Amelie DELAUNAY <firstname.lastname@example.org> To: Lee Jones <email@example.com> Cc: Linus Walleij <firstname.lastname@example.org>, Rob Herring <email@example.com>, Mark Rutland <firstname.lastname@example.org>, Russell King <email@example.com>, Alexandre TORGUE <firstname.lastname@example.org>, Maxime Coquelin <email@example.com>, "open list:GPIO SUBSYSTEM" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <email@example.com>, Linux ARM <firstname.lastname@example.org> Subject: Re: [PATCH 1/5] dt-bindings: pinctrl: document the STMFX pinctrl bindings Date: Fri, 18 May 2018 07:29:04 +0000 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20180517063640.GK5130@dell> On 05/17/2018 08:36 AM, Lee Jones wrote: > On Wed, 16 May 2018, Amelie DELAUNAY wrote: > >> >> >> On 05/16/2018 04:20 PM, Linus Walleij wrote: >>> On Wed, May 9, 2018 at 9:56 AM, Amelie DELAUNAY <firstname.lastname@example.org> wrote: >>> >>>> Indeed, stmfx has other functions than GPIO. But, after comments done >>>> here:  and there: , it has been decided to move MFD parent/GPIO >>>> child drivers into a single PINCTRL/GPIO driver because of the following >>>> reasons: >>>> - Other stmfx functions (IDD measurement and TouchScreen controller) are >>>> not used on any of the boards using an stmfx and supported by Linux, so >>>> no way to test these functions, and no need to maintain them while they >>>> are not being used. >>>> - But, in the case a new board will use more than GPIO function on >>>> stmfx, the actual implementation allow to easily extract common init >>>> part of stmfx and put it in an MFD driver. >>>> >>>> So I could remove gpio sub-node and put its contents in stmfx node and >>>> keep single PINCTRL/GPIO driver for the time being. >>>> Please advise, >>> >>> I would normally advice to use the right modeling from the start, create >>> the MFD driver and spawn the devices from there. It is confusing >>> if the layout of the driver(s) doesn't really match the layout of the >>> hardware. >>> >>> I understand that it is a pain to write new MFD drivers to get your >>> things going and it would be "nice to get this working really quick >>> now" but in my experience it is better to do it right from the start. >>> >> >> Hi Linus, >> >> Thanks for your advice. I understand the point. >> So, the right modeling would be to: >> - create an MFD driver with the common init part of stmfx >> - remove all common init part of stmfx-pinctrl driver and keep only all >> gpio/pinctrl functions. >> >> I will not develop the other stmfx functions (IDD measurement driver and >> TouchScreen controller driver) because, as explained ealier, they are >> not used on any of the boards using an stmfx and supported by Linux, so >> no way to test these functions, and no need to maintain them while they >> are not being used. >> >> Lee, are you OK with that ? > > I missed a lot of this conversation I think, but from what I've read, > it sounds fine. > I summarize the situation: - I still don't have an official datasheet for STMFX device which could justify the use of an MFD driver; - the MFD driver will contain the STMFX chip initialization stuff such as regmap initialization (regmap structure will be shared with the child), chip initialization, global interrupt management; - there will be only one child (GPIO/PINCTRL node) for the time being. So, is "MFD driver + GPIO/PINCTRL driver" the right modeling, and does it still sound fine after this summary ? :) Thanks, Amelie
next prev parent reply other threads:[~2018-05-18 7:29 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-11 9:47 [PATCH 0/5] Introduce STMFX I2C GPIO expander Amelie Delaunay 2018-04-11 9:47 ` [PATCH 1/5] dt-bindings: pinctrl: document the STMFX pinctrl bindings Amelie Delaunay 2018-04-16 18:19 ` Rob Herring 2018-04-26 12:49 ` Linus Walleij 2018-05-09 7:56 ` Amelie DELAUNAY 2018-05-16 14:20 ` Linus Walleij 2018-05-16 15:01 ` Amelie DELAUNAY 2018-05-17 6:36 ` Lee Jones 2018-05-18 7:29 ` Amelie DELAUNAY [this message] 2018-05-18 13:52 ` Lee Jones 2018-05-18 15:13 ` Amelie DELAUNAY 2018-05-24 7:13 ` Linus Walleij 2018-05-28 11:39 ` Amelie DELAUNAY 2018-05-29 7:36 ` Lee Jones 2018-05-09 7:31 ` Amelie DELAUNAY 2018-04-11 9:47 ` [PATCH 2/5] pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver Amelie Delaunay 2018-04-12 3:11 ` kbuild test robot 2018-04-26 12:48 ` Linus Walleij 2018-05-09 9:13 ` Amelie DELAUNAY 2018-04-11 9:47 ` [PATCH 3/5] ARM: dts: stm32: add STMFX pinctrl/gpio expander support on stm32746g-eval Amelie Delaunay 2018-04-11 9:47 ` [PATCH 4/5] ARM: dts: stm32: add orange and blue leds " Amelie Delaunay 2018-04-11 9:47 ` [PATCH 5/5] ARM: dts: stm32: add joystick support " Amelie Delaunay
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).