LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Tony Krowiak <akrowiak@linux.vnet.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
Cc: borntraeger@de.ibm.com, cohuck@redhat.com,
	pmorel@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
	pbonzini@redhat.com, rkrcmar@redhat.com
Subject: Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus
Date: Sun, 22 Apr 2018 17:53:21 +0200	[thread overview]
Message-ID: <28eacee1-eafe-dc95-c008-61bc656b931c@linux.ibm.com> (raw)
In-Reply-To: <d6e8e85b-525e-906a-3c17-ea5faef143cb@linux.vnet.ibm.com>



On 04/22/2018 05:06 PM, Tony Krowiak wrote:
> On 04/20/2018 08:26 AM, David Hildenbrand wrote:
>> On 19.04.2018 23:13, Tony Krowiak wrote:
>>> Introduces a new function to reset the crypto attributes for all
>>> vcpus whether they are running or not. Each vcpu in KVM will
>>> be removed from SIE prior to resetting the crypto attributes in its
>>> SIE state description. After all vcpus have had their crypto attributes
>>> reset the vcpus will be restored to SIE.
>>>
>>> This function is incorporated into the kvm_s390_vm_set_crypto(kvm)
>>> function to fix a reported issue whereby the crypto key wrapping
>>> attributes could potentially get out of synch for running vcpus.
>>>
>>> Reported-by: Halil Pasic <pasic@linux.vnet.ibm.com>
>> A reported-by for a code refactoring is strange.
> 
> I was asked to include this.

Is this a refactoring or a fix? I the message you state that you are
fixing an issue (aka bug). If you are not, fixing an issue, but indeed
just refactoring, Suggested-by would be more appropriate.

Regards,
Halil

  reply	other threads:[~2018-04-22 15:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 21:13 Tony Krowiak
2018-04-20  8:57 ` Cornelia Huck
2018-04-20 11:59 ` Janosch Frank
2018-04-20 12:15   ` Janosch Frank
2018-04-22 15:10     ` Tony Krowiak
2018-04-20 12:26 ` David Hildenbrand
2018-04-20 12:28   ` David Hildenbrand
2018-04-22 15:06   ` Tony Krowiak
2018-04-22 15:53     ` Halil Pasic [this message]
2018-04-21  0:11 ` kbuild test robot
2018-04-22 16:42   ` Tony Krowiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28eacee1-eafe-dc95-c008-61bc656b931c@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=akrowiak@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=rkrcmar@redhat.com \
    --subject='Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).