LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.io>
To: Kyle Tso <kyletso@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR
Date: Thu, 19 Aug 2021 00:24:41 +0800	[thread overview]
Message-ID: <29ac3b3b11fa022c6411fe3d334cceb6146b2978.camel@aosc.io> (raw)
In-Reply-To: <CAGZ6i=2a6ueLghhDTPCP_gumZ=HUYWRLCKkveyVnNQLgP+zyow@mail.gmail.com>

在 2021-08-19星期四的 00:13 +0800,Kyle Tso写道:
> On Wed, Aug 18, 2021 at 10:40 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > 
> > On Wed, Aug 18, 2021 at 10:02:24PM +0800, Icenowy Zheng wrote:
> > > 
> > > 
> > > 于 2021年8月18日 GMT+08:00 下午9:56:38, Greg Kroah-Hartman < 
> > > gregkh@linuxfoundation.org> 写到:
> > > > On Tue, Aug 17, 2021 at 02:00:33PM +0300, Heikki Krogerus
> > > > wrote:
> > > > > > > Why is it necessary to do discovery with data role swap
> > > > > > > in general?
> > > > > > 
> > > > > > I think it could be possible for devices to expose
> > > > > > different altmode
> > > > > > with different role.
> > > > > 
> > > > > OK. FWIW:
> > > > > 
> > > > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > > 
> > > > Is this conflicting with  
> > > > https://lore.kernel.org/r/20210816075449.2236547-1-kyletso@google.com
> > > >  ?
> > > > 
> > > > Which of these two should I take, both?  Neither?
> > > 
> > > Don't take this, it's against spec.
> > 
> > Ok, now dropped.  What about the linked patch above?  Does that
> > work for
> > you instead?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Icenowy,
> 
> Could you revisit the patch for the tcpm_unregister_altmodes part?
> I think that is still a problem.

Well, I must admit that only doing a tcpm_unregister_altmodes() should
be harmless.

> 
> thanks,
> Kyle


  parent reply	other threads:[~2021-08-18 16:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  4:31 Icenowy Zheng
2021-08-17  9:36 ` Heikki Krogerus
2021-08-17  9:41   ` Icenowy Zheng
2021-08-17 11:00     ` Heikki Krogerus
2021-08-18 13:56       ` Greg Kroah-Hartman
2021-08-18 14:02         ` Icenowy Zheng
2021-08-18 14:40           ` Greg Kroah-Hartman
2021-08-18 16:13             ` Kyle Tso
2021-08-18 16:17               ` Icenowy Zheng
2021-08-18 16:24               ` Icenowy Zheng [this message]
2021-08-17 15:13   ` Guenter Roeck
2021-08-18  8:02     ` Kyle Tso
2021-08-18  8:16       ` Kyle Tso
2021-08-18  9:20       ` Icenowy Zheng
2021-08-18  9:27       ` Icenowy Zheng
2021-08-18 10:47         ` Kyle Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29ac3b3b11fa022c6411fe3d334cceb6146b2978.camel@aosc.io \
    --to=icenowy@aosc.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=kyletso@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --subject='Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).