LKML Archive on
help / color / mirror / Atom feed
From: Eric Dumazet <>
To: Andy Lutomirski <>, Eric Dumazet <>
Cc: Soheil Hassas Yeganeh <>,
	Eric Dumazet <>,
	"David S. Miller" <>,
	Network Development <>,
	LKML <>,
	Linux-MM <>
Subject: Re: [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive
Date: Thu, 26 Apr 2018 14:40:59 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 04/26/2018 02:16 PM, Andy Lutomirski wrote:
> At the risk of further muddying the waters, there's another minor tweak
> that could improve performance on certain workloads.  Currently you mmap()
> a range for a given socket and then getsockopt() to receive.  If you made
> it so you could mmap() something once for any number of sockets (by
> mmapping /dev/misc/tcp_zero_receive or whatever), then the performance of
> the getsockopt() bit would be identical, but you could release the mapping
> for many sockets at once with only a single flush.  For some use cases,
> this could be a big win.
> You could also add this later easily enough, too.

I believe I implemented what you just described.

The getsockopt() call checks that the VMA was created by a mmap() to one TCP socket.

It does not check that the vma was created by mmap() on the same socket,
because we do not need this extra check really.

So you presumably could use mmap() to grab 1GB of virtual space, then split it
as you wish for different sockets.


      reply	other threads:[~2018-04-26 21:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 21:43 Eric Dumazet
2018-04-25 21:43 ` [PATCH v2 net-next 1/2] tcp: add TCP_ZEROCOPY_RECEIVE support for " Eric Dumazet
2018-04-26 13:40   ` Ka-Cheong Poon
2018-04-26 13:47     ` Eric Dumazet
2018-04-27  8:44   ` kbuild test robot
2018-04-27 13:03     ` Eric Dumazet
2018-04-25 21:43 ` [PATCH v2 net-next 2/2] selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE Eric Dumazet
2018-04-26  1:20 ` [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive Soheil Hassas Yeganeh
2018-04-26 14:56   ` Eric Dumazet
2018-04-26 21:16     ` Andy Lutomirski
2018-04-26 21:40       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).