LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Thara Gopinath" <thara.gopinath@linaro.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build
Date: Sun, 22 Aug 2021 14:08:08 -0700	[thread overview]
Message-ID: <2bf9925a-fad9-ad9a-c878-daa08fae7e07@infradead.org> (raw)
In-Reply-To: <438052.1629663003@turing-police>

On 8/22/21 1:10 PM, Valdis Klētnieks wrote:
> Commit 86afc1df661a adds a reference to a symbol that doesn't have an
> EXPORT_SYMBOL, which fails if qcom-cpufreq-hw is built as a module.
> 
> ERROR: modpost: "topology_set_thermal_pressure" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
> 
> Add the missing EXPORT_SYMBOL.
> 
> Fixes: 86afc1df661a ("cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support")
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> ---
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 921312a8d957..fbc39ca67124 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -165,6 +165,7 @@ void topology_set_thermal_pressure(const struct cpumask *cpus,
>   	for_each_cpu(cpu, cpus)
>   		WRITE_ONCE(per_cpu(thermal_pressure, cpu), th_pressure);
>   }
> +EXPORT_SYMBOL(topology_set_thermal_pressure);
>   
>   static ssize_t cpu_capacity_show(struct device *dev,
>   				 struct device_attribute *attr,
> 

Hi Valdis,

This fixes one build error for me but I am still seeing another one:

ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!

thanks.
-- 
~Randy


  reply	other threads:[~2021-08-22 21:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22 20:10 Valdis Klētnieks
2021-08-22 21:08 ` Randy Dunlap [this message]
2021-08-22 21:14   ` Valdis Klētnieks
2021-08-24  9:14     ` SeongJae Park
2021-08-25  2:16       ` Valdis Klētnieks
2021-08-25  4:41         ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf9925a-fad9-ad9a-c878-daa08fae7e07@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --cc=valdis.kletnieks@vt.edu \
    --subject='Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix '\''make allmodconfig'\'' build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).