LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ray Lee" <ray-lk@madrabbit.org>
To: "Carlos Corbacho" <carlos@strangeworlds.co.uk>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Len Brown" <lenb@kernel.org>,
	"kernel list" <linux-kernel@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.osdl.org>,
	linux-acpi@vger.kernel.org
Subject: Re: ACPI_WMI: worst config description of all times
Date: Thu, 7 Feb 2008 16:12:24 -0800	[thread overview]
Message-ID: <2c0942db0802071612r1b32f996jc26ac3792b8c31fc@mail.gmail.com> (raw)
In-Reply-To: <200802072351.32521.carlos@strangeworlds.co.uk>

On Feb 7, 2008 3:51 PM, Carlos Corbacho <carlos@strangeworlds.co.uk> wrote:
> On Thursday 07 February 2008 23:33:54 Ray Lee wrote:
> > Do you have list of hardware/platforms that require this feature to
> > get the hardware to work? (acer abc123, tcm1100 xyz)
>
> I have a very long list of Acer laptops that are supported - which is far too
> long, and changes on far too much of a regular basis to put in there.
>
> Perhaps adding something like "This driver is also a required dependency to
> build the firmware specific drivers needed for many laptops, including Acer
> and HP machines"?

<nod>

> (There's currently another ACPI-WMI based driver in development related to
> more HP laptops, and acer-wmi also supports a handful of non-Acer laptops).
>
> I don't think explaining what WMI is, and how ACPI-WMI is related to it is
> that useful in Kconfig here; so I agree that further elaborating on the 'why'
> this should be enabled is definitely worth doing.
>
> > Better, if there are kernel drivers that require this (and currently
> > only those drivers), then have those kernel drivers enable ACPI WMI,
>
> Wouldn't that require 'select' though, and I'm led to believe that's seriously
> frowned upon these days?

Depends who you talk to. It's certainly the fodder for a yearly flamewar.

While I'm not trying to set you up for a firing squad, if you can show
that the only use this driver has is as underlying support for Acer/HP
xyz drivers, and that those drivers require this one, then that
situation really is what select is in there for. Anyone who argues
against using select in that case is really just arguing against the
mere existence of the kconfig select keyword itself.

  reply	other threads:[~2008-02-08  0:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 21:47 Pavel Machek
2008-02-07 22:27 ` Len Brown
2008-02-07 22:34   ` Pavel Machek
2008-02-07 23:18     ` Carlos Corbacho
2008-02-07 23:33       ` Ray Lee
2008-02-07 23:51         ` Carlos Corbacho
2008-02-08  0:12           ` Ray Lee [this message]
2008-02-08  0:27             ` Carlos Corbacho
2008-02-08  6:53               ` Pavel Machek
2008-02-08  9:37                 ` Carlos Corbacho
2008-02-08  1:19             ` Carlos Corbacho
2008-02-08  1:38               ` Ray Lee
2008-02-08  2:02                 ` Carlos Corbacho
2008-02-08  5:43                   ` Len Brown
2008-02-08  5:26               ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0942db0802071612r1b32f996jc26ac3792b8c31fc@mail.gmail.com \
    --to=ray-lk@madrabbit.org \
    --cc=carlos@strangeworlds.co.uk \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    --subject='Re: ACPI_WMI: worst config description of all times' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).