LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ray Lee" <ray-lk@madrabbit.org>
To: "Carlos Corbacho" <carlos@strangeworlds.co.uk>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Len Brown" <lenb@kernel.org>,
	"kernel list" <linux-kernel@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.osdl.org>,
	linux-acpi@vger.kernel.org
Subject: Re: ACPI_WMI: worst config description of all times
Date: Thu, 7 Feb 2008 17:38:01 -0800	[thread overview]
Message-ID: <2c0942db0802071738g2f426d4y6ee9ab58b62d8174@mail.gmail.com> (raw)
In-Reply-To: <200802080119.08872.carlos@strangeworlds.co.uk>

On Feb 7, 2008 5:19 PM, Carlos Corbacho <carlos@strangeworlds.co.uk> wrote:
> On Friday 08 February 2008 00:12:24 Ray Lee wrote:
> > On Feb 7, 2008 3:51 PM, Carlos Corbacho <carlos@strangeworlds.co.uk> wrote:
> > > On Thursday 07 February 2008 23:33:54 Ray Lee wrote:
> > > > Do you have list of hardware/platforms that require this feature to
> > > > get the hardware to work? (acer abc123, tcm1100 xyz)
> > >
> > > I have a very long list of Acer laptops that are supported - which is far
> > > too long, and changes on far too much of a regular basis to put in there.
> > >
> > > Perhaps adding something like "This driver is also a required dependency
> > > to build the firmware specific drivers needed for many laptops, including
> > > Acer and HP machines"?
>
> Would this be acceptable then?
>
> -Carlos
> ---
> ACPI: WMI: Improve Kconfig entry
>
> From: Carlos Corbacho <carlos@strangeworlds.co.uk>
>
> As Pavel Machek has pointed out, the Kconfig entry for WMI is pretty
> non-descriptive.
>
> Rewrite it so that it explains what ACPI-WMI is, and why anyone
> would want to enable it.
>
> Many thanks to Ray Lee for ideas on this.
>
> Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
> CC: Pavel Machek <pavel@ucw.cz>
> CC: Ray Lee <ray-lk@madrabbit.org>
> CC: Len Brown <lenb@kernel.org>
> ---
>
>  drivers/acpi/Kconfig |   19 +++++++++++++++----
>  1 files changed, 15 insertions(+), 4 deletions(-)
>
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7fbf16..ea763ef 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -207,11 +207,22 @@ config ACPI_WMI
>         depends on EXPERIMENTAL
>         depends on X86
>         help
> -         This driver adds support for the ACPI-WMI mapper device (PNP0C14)
> -         found on some systems.
> +         This driver adds support for the ACPI-WMI (Windows Management
> +         Instrumentation) mapper device (PNP0C14) found on some systems.
>
> -         NOTE: You will need another driver or userspace application on top of
> -         this to actually use anything defined in the ACPI-WMI mapper.
> +         ACPI-WMI is a proprietary extension to ACPI to expose parts of the
> +         ACPI firmware to userspace - this is done through various vendor
> +         defined methods and data blocks in a PNP0C14 device, which are then
> +         made available for userspace to call.
> +
> +         The implementation of this in Linux currently only exposes this to
> +         other kernel space drivers.
> +
> +         This driver is a required dependency to build the firmware specific
> +         drivers needed on many machines, including Acer and HP laptops.
> +
> +         It is safe to enable this driver even if your DSDT doesn't define
> +         any ACPI-WMI devices.
>
>  config ACPI_ASUS
>          tristate "ASUS/Medion Laptop Extras"
>

<nod> That's clear to me (whereas the original wasn't), though I would
still argue for this driver being select'ed by the drivers that
require it. As you note, other laptop specific drivers do so, and
Linus has come down in favor of that as well in the past, so you have
a friend in high places :-).

  reply	other threads:[~2008-02-08  1:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 21:47 Pavel Machek
2008-02-07 22:27 ` Len Brown
2008-02-07 22:34   ` Pavel Machek
2008-02-07 23:18     ` Carlos Corbacho
2008-02-07 23:33       ` Ray Lee
2008-02-07 23:51         ` Carlos Corbacho
2008-02-08  0:12           ` Ray Lee
2008-02-08  0:27             ` Carlos Corbacho
2008-02-08  6:53               ` Pavel Machek
2008-02-08  9:37                 ` Carlos Corbacho
2008-02-08  1:19             ` Carlos Corbacho
2008-02-08  1:38               ` Ray Lee [this message]
2008-02-08  2:02                 ` Carlos Corbacho
2008-02-08  5:43                   ` Len Brown
2008-02-08  5:26               ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0942db0802071738g2f426d4y6ee9ab58b62d8174@mail.gmail.com \
    --to=ray-lk@madrabbit.org \
    --cc=carlos@strangeworlds.co.uk \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    --subject='Re: ACPI_WMI: worst config description of all times' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).