LKML Archive on
help / color / mirror / Atom feed
From: Gary R Hook <>
To: Jani Nikula <>,
Subject: Re: [PATCH] Documentation/CodingStyle: Add an example for braces
Date: Thu, 15 Mar 2018 14:54:26 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 03/15/2018 05:26 AM, Jani Nikula wrote:
> On Wed, 14 Mar 2018, Gary R Hook <> wrote:
>> Add another example of required braces when using a compound statement in
>> a loop.
>> Signed-off-by: Gary R Hook <>
>> ---
>>   Documentation/process/coding-style.rst |    9 +++++++++
>>   1 file changed, 9 insertions(+)
>> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
>> index a20b44a40ec4..d98deb62c400 100644
>> --- a/Documentation/process/coding-style.rst
>> +++ b/Documentation/process/coding-style.rst
>> @@ -200,6 +200,15 @@ statement; in the latter case use braces in both branches:
>>   		otherwise();
>>   	}
>> +Also, use braces when a loop contains more than a single simple statement:
> Personally, I'd not limit this to loops.
> 	if (condition) {
>          	if (another_condition)
>                  	action();
>          }
> You could argue the existing rule already covers these cases by
> excluding selection and iteration statements from the "single statement"
> in "Do not unnecessarily use braces where a single statement will do."

Define "statement"? There's a school of thought that uses semicolons to 
indicate a statement. I'm trying to eliminate any ambiguity by calling 
out compound statements as "more than one statement". Sure, semantics,
but in the interest of clarity. An additional sentence and example 
doesn't really cost much.

Thank you for your time. I've made some changes, and a v2 to follow shortly.

      reply	other threads:[~2018-03-15 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 22:21 [PATCH] Documentation/CodingStyle: Add an example for braces Gary R Hook
2018-03-15 10:26 ` Jani Nikula
2018-03-15 19:54   ` Gary R Hook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).