LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: 李扬韬 <frank.li@vivo.com>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] f2fs: Reduce the scope of setting fsck tag when de->name_len is zero
Date: Wed, 4 Aug 2021 11:32:59 +0800	[thread overview]
Message-ID: <2c59c14b-008c-aee9-6775-13b47fbd252f@kernel.org> (raw)
In-Reply-To: <AJcAmwDXD1QzgUCoyu2cQKql.3.1626784315314.Hmail.frank.li@vivo.com>

Hello, Yangtao,

I did some cleanup in your patch, and resend for you, please
note that. :)

Thanks,

On 2021/7/20 20:31, 李扬韬 wrote:
> HI Chao,
> 
> From: Chao Yu <chao@kernel.org>
> Date: 2021-07-20 18:23:15
> To:  Yangtao Li <frank.li@vivo.com>,jaegeuk@kernel.org
> Cc:  linux-f2fs-devel@lists.sourceforge.net,linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] f2fs: Reduce the scope of setting fsck tag when de->name_len is zero>On 2021/7/20 15:06, Yangtao Li wrote:
>>> I recently found a case where de->name_len is 0 in f2fs_fill_dentries() easily reproduced,
>>> and finally set the fsck flag.
>>>
>>> Thread A					Thread B
>>>
>>> f2fs_readdir
>>> 	f2fs_read_inline_dir
>>> 		ctx->pos = d.max
>>> 						f2fs_add_dentry
>>> 							f2fs_add_inline_entry
>>> 								do_convert_inline_dir
>>> 							f2fs_add_regular_entry
>>> f2fs_readdir
>>> 	f2fs_fill_dentries
>>> 		set_sbi_flag(sbi, SBI_NEED_FSCK)
>>>
>>> Process A opens the folder, and has been reading without closing it. During this period,
>>> Process B created a file under the folder (occupying multiple f2fs_dir_entry, exceeding
>>> the d.max of the inline dir). After creation, process A uses the d.max of inline dir to
>>> read it again, and it will read that de->name_len is 0.
>>>
>>> And Chao pointed out that w/o inline conversion, the race condition still can happen as below
>>>
>>> dir_entry1: A
>>> dir_entry2: B
>>> dir_entry3: C
>>> free slot: _
>>> ctx->pos: ^
>>>
>>> Before:
>>> AAAABBBB___
>>> 	 ^
>>
>> please use blank instead of tab before '^'
> 
> I don't know exactly what happened. In fact, in v2, spaces were used. Then it was changed to tab in v3.
> 
>>
>>> Thread B delete dir_entry2, and create dir_entry3.
>>>
>>> After:
>>> AAAACCCCC__
>>> 	 ^
>>
>> Ditto
>>
>>>
>>> In these scenarios, the file system is not damaged, and it's hard to avoid it. But we can bypass
>>> tagging FSCK flag if:
>>> a) bit_pos (:= ctx->pos % d->max) is non-zero & b) before bit_pos moves to first
>>> valid dir_entry.
>>>
>>> Signed-off-by: Yangtao Li <frank.li@vivo.com>
>>> ---
>>>    fs/f2fs/dir.c | 14 +++++++++-----
>>>    1 file changed, 9 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
>>> index 456651682daf..bfe942733b5e 100644
>>> --- a/fs/f2fs/dir.c
>>> +++ b/fs/f2fs/dir.c
>>> @@ -1000,6 +1000,7 @@ int f2fs_fill_dentries(struct dir_context *ctx, struct f2fs_dentry_ptr *d,
>>>    	struct f2fs_sb_info *sbi = F2FS_I_SB(d->inode);
>>>    	struct blk_plug plug;
>>>    	bool readdir_ra = sbi->readdir_ra == 1;
>>> +	bool found_valid_dirent  = false;
>>
>> One more blank before '='.
>>
>> bool found_valid_dirent = false;
>>
> 
> OK.
> 
> Thx,
> 
> 
> 

      reply	other threads:[~2021-08-04  3:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  7:06 Yangtao Li
2021-07-20 10:23 ` Chao Yu
2021-07-20 12:31   ` 李扬韬
2021-08-04  3:32     ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c59c14b-008c-aee9-6775-13b47fbd252f@kernel.org \
    --to=chao@kernel.org \
    --cc=frank.li@vivo.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v3] f2fs: Reduce the scope of setting fsck tag when de->name_len is zero' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).