LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kirti Wankhede <kwankhede@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<cohuck@redhat.com>, <pasic@linux.ibm.com>
Subject: Re: [PATCH v4 0/2] vfio/mdev: Device namespace protection
Date: Sat, 19 May 2018 01:07:33 +0530	[thread overview]
Message-ID: <2cb44337-eea6-5953-3df9-b53f3f6e3301@nvidia.com> (raw)
In-Reply-To: <20180518190145.3187.7620.stgit@gimli.home>



On 5/19/2018 12:40 AM, Alex Williamson wrote:
> v4: Fix the 'create' racing 'remove' gap noted by Kirti by moving
>     removal from mdev_list to mdev_device_release().  Fix missing
>     mdev_put_parent() cases in mdev_device_create(), also noted
>     by Kirti.  Added documention update regarding serialization as
>     noted by Cornelia.  Added additional commit log comment about
>     -EAGAIN vs -ENODEV for 'remove' racing 'create'.  Added second
>     patch to re-order sysfs attributes, with this my targeted
>     scripts can no longer hit the gap where -EAGAIN is regurned.
>     BTW, the gap where the current code returns -ENODEV in this
>     race condition is about 50% easier to hit than it exists in
>     this series with patch 1 alone.
> 

Thanks for fixing this. This patch set looks good to me.

Thanks,
Kirti

> Thanks,
> Alex
> 
> ---
> 
> Alex Williamson (2):
>       vfio/mdev: Check globally for duplicate devices
>       vfio/mdev: Re-order sysfs attribute creation
> 
> 
>  Documentation/vfio-mediated-device.txt |    5 ++
>  drivers/vfio/mdev/mdev_core.c          |  102 +++++++++++---------------------
>  drivers/vfio/mdev/mdev_private.h       |    2 -
>  drivers/vfio/mdev/mdev_sysfs.c         |   14 ++--
>  4 files changed, 49 insertions(+), 74 deletions(-)
> 

  parent reply	other threads:[~2018-05-18 19:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 19:10 Alex Williamson
2018-05-18 19:10 ` [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices Alex Williamson
2018-05-18 19:37   ` Kirti Wankhede
2018-05-22  8:13   ` Cornelia Huck
2018-05-22 15:53     ` Alex Williamson
2018-05-23  4:53       ` Zhenyu Wang
2018-05-18 19:10 ` [PATCH v4 2/2] vfio/mdev: Re-order sysfs attribute creation Alex Williamson
2018-05-18 19:38   ` Kirti Wankhede
2018-05-22  8:14   ` Cornelia Huck
2018-05-18 19:37 ` Kirti Wankhede [this message]
2018-05-22 17:17 ` [PATCH v4 0/2] vfio/mdev: Device namespace protection Halil Pasic
2018-05-22 18:38   ` Alex Williamson
2018-05-23  8:56     ` Cornelia Huck
2018-05-23 12:29       ` Halil Pasic
2018-05-23 13:34         ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cb44337-eea6-5953-3df9-b53f3f6e3301@nvidia.com \
    --to=kwankhede@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    --subject='Re: [PATCH v4 0/2] vfio/mdev: Device namespace protection' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).