LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Affinity for GIC irq line
@ 2018-04-25  3:23 valmiki
  2018-04-25  7:07 ` Marc Zyngier
  0 siblings, 1 reply; 3+ messages in thread
From: valmiki @ 2018-04-25  3:23 UTC (permalink / raw)
  To: linux-kernel; +Cc: Marc Zyngier, tglx, jason, Catalin Marinas

Hi all,

When an IRQ line is set affinity using irq_set_affinity, which calls 
irq_do_set_affinity, this API copies affinity mask to affinity variable 
in irq_common_data of this irq descriptor.

But as per ARM GICv2 document in order to drive a interrupt to a 
specific CPU we need to program GICD_ITARGETSRn register.

But irq_set_affinity isn't writing to this register.Please correct me if 
I'm wrong i did not find code for this register being updated in 
irq_set_affinity flow.
So how affinity is being set for an IRQ line ?

If affinity was set successfully on what CPU does asm_do_IRQ run ?
For every interrupt this runs on CPU0 and then FIQ/IRQ handling is 
scheduled on different CPU as per affinity ?
How the respective irq line handler is handled on specific CPU core ?

Regards,
Valmiki


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Affinity for GIC irq line
  2018-04-25  3:23 Affinity for GIC irq line valmiki
@ 2018-04-25  7:07 ` Marc Zyngier
  2018-04-26  3:49   ` valmiki
  0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2018-04-25  7:07 UTC (permalink / raw)
  To: valmiki, linux-kernel; +Cc: tglx, jason, Catalin Marinas

On 25/04/18 04:23, valmiki wrote:
> Hi all,
> 
> When an IRQ line is set affinity using irq_set_affinity, which calls 
> irq_do_set_affinity, this API copies affinity mask to affinity variable 
> in irq_common_data of this irq descriptor.

It does a wee bit more. Crucially, it contains the line:

        ret = chip->irq_set_affinity(data, mask, force);

> But as per ARM GICv2 document in order to drive a interrupt to a 
> specific CPU we need to program GICD_ITARGETSRn register.
> 
> But irq_set_affinity isn't writing to this register.Please correct me if 
> I'm wrong i did not find code for this register being updated in 
> irq_set_affinity flow.
> So how affinity is being set for an IRQ line ?

I would have though that a function name such as "gic_set_affinity" was
clear enough?

> If affinity was set successfully on what CPU does asm_do_IRQ run ?

It runs on the CPU that the interrupt targets, I'd say.

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Affinity for GIC irq line
  2018-04-25  7:07 ` Marc Zyngier
@ 2018-04-26  3:49   ` valmiki
  0 siblings, 0 replies; 3+ messages in thread
From: valmiki @ 2018-04-26  3:49 UTC (permalink / raw)
  To: Marc Zyngier, linux-kernel; +Cc: tglx, jason, Catalin Marinas

> On 25/04/18 04:23, valmiki wrote:
>> Hi all,
>>
>> When an IRQ line is set affinity using irq_set_affinity, which calls
>> irq_do_set_affinity, this API copies affinity mask to affinity variable
>> in irq_common_data of this irq descriptor.
>
> It does a wee bit more. Crucially, it contains the line:
>
>         ret = chip->irq_set_affinity(data, mask, force);
Yes, i overlooked this part.
>
>> But as per ARM GICv2 document in order to drive a interrupt to a
>> specific CPU we need to program GICD_ITARGETSRn register.
>>
>> But irq_set_affinity isn't writing to this register.Please correct me if
>> I'm wrong i did not find code for this register being updated in
>> irq_set_affinity flow.
>> So how affinity is being set for an IRQ line ?
>
> I would have though that a function name such as "gic_set_affinity" was
> clear enough?
>
>> If affinity was set successfully on what CPU does asm_do_IRQ run ?
>
> It runs on the CPU that the interrupt targets, I'd say.
Thanks Marc.
How does affinity for virtual irq work ?
For example pci-xgene-msi.c has xgene_msi_set_affinity function which 
sets affinity for each virq.
As per arm64/boot/dts/apm/apm-storm.dtsi they use GICv2.
They are trying to map each virq to specific cpu but already GIC lines 
affinity is set, when this affinity would be used ?

What does
/* Update MSI number to target the new CPU */
irqdata->hwirq = hwirq_to_canonical_hwirq(irqdata->hwirq) + target_cpu;

the above code do ?
Already mapping for hwirq to virq is done by this time for this domain.
Now if hwirq is updated its mapping doesn't it lead to wrong virq ?

Regards,
Valmiki


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-26  3:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25  3:23 Affinity for GIC irq line valmiki
2018-04-25  7:07 ` Marc Zyngier
2018-04-26  3:49   ` valmiki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).