LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: khsieh@codeaurora.org, Jani Nikula <jani.nikula@linux.intel.com>
Cc: robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org,
	abhinavk@codeaurora.org, aravindh@codeaurora.org,
	rsubbia@codeaurora.org, rnayak@codeaurora.org,
	freedreno@lists.freedesktop.org, airlied@linux.ie,
	daniel@ffwll.ch, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
Date: Thu, 22 Jul 2021 13:53:34 -0400	[thread overview]
Message-ID: <2da3949fa3504592da42c9d01dc060691c6a8b8b.camel@redhat.com> (raw)
In-Reply-To: <a514c19f712a6feeddf854dc17cb8eb5@codeaurora.org>

On Tue, 2021-07-13 at 15:24 -0700, khsieh@codeaurora.org wrote:
> On 2021-07-07 01:37, Jani Nikula wrote:
> > On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote:
> > > From: Rajkumar Subbiah <rsubbia@codeaurora.org>
> > > 
> > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
> > > selftests") added some debug code for sideband message tracing. But
> > > it seems to have unintentionally changed the behavior on sideband 
> > > message
> > > failure. It catches and returns failure only if DRM_UT_DP is enabled.
> > > Otherwise it ignores the error code and returns success. So on an MST
> > > unplug, the caller is unaware that the clear payload message failed 
> > > and
> > > ends up waiting for 4 seconds for the response. Fixes the issue by
> > > returning the proper error code.
> > > 
> > > Changes in V2:
> > > -- Revise commit text as review comment
> > > -- add Fixes text
> > > 
> > > Changes in V3:
> > > -- remove "unlikely" optimization
> > > 
> > > Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + 
> > > selftests")
> > > 
> > > Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
> > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
> > > 
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > 
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > 
> > 
> > > ---
> Lyude,
> Any comments from you?
> Thanks,

Hey! Sorry did I forget to respond to this?

Reviewed-by: Lyude Paul <lyude@redhat.com>

> 
> > >  drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
> > > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > index 1590144..df91110 100644
> > > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct 
> > > drm_dp_mst_topology_mgr *mgr,
> > >         idx += tosend + 1;
> > > 
> > >         ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
> > > -       if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
> > > -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> > > +       if (ret) {
> > > +               if (drm_debug_enabled(DRM_UT_DP)) {
> > > +                       struct drm_printer p =
> > > drm_debug_printer(DBG_PREFIX);
> > > 
> > > -               drm_printf(&p, "sideband msg failed to send\n");
> > > -               drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> > > +                       drm_printf(&p, "sideband msg failed to send\n");
> > > +                       drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> > > +               }
> > >                 return ret;
> > >         }
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


  reply	other threads:[~2021-07-22 17:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 15:30 Kuogee Hsieh
2021-07-07  8:37 ` Jani Nikula
2021-07-13 22:24   ` khsieh
2021-07-22 17:53     ` Lyude Paul [this message]
2021-07-22 22:28       ` khsieh
2021-07-27 19:21         ` Lyude Paul
2021-07-27 22:41           ` khsieh
2021-07-27 22:44             ` Lyude Paul
2021-08-25 16:06               ` khsieh
2021-08-25 16:26                 ` Lyude Paul
2021-08-30 15:56                   ` khsieh
2021-08-30 16:58                     ` Lyude Paul
2021-08-30 22:57                       ` Stephen Boyd
2021-09-07 20:47                       ` khsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2da3949fa3504592da42c9d01dc060691c6a8b8b.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=aravindh@codeaurora.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=khsieh@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=robdclark@gmail.com \
    --cc=rsubbia@codeaurora.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    --cc=tzimmermann@suse.de \
    --subject='Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).