LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Pratik Jain <pratik.jain0509@gmail.com>, greg@kroah.com
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue
Date: Fri, 16 Mar 2018 10:17:28 +0000	[thread overview]
Message-ID: <2dd4e733-b74a-c296-a554-3520a85e8ce2@mev.co.uk> (raw)
In-Reply-To: <20180315185943.18902-1-pratik.jain0509@gmail.com>

On 15/03/2018 18:59, Pratik Jain wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Pratik Jain <pratik.jain0509@gmail.com>
> ---
>   drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index b9e9ab548c4b..4e27a2959b64 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -226,8 +226,8 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
>   	for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {
>   		isapnp_dev = pnp_find_dev(NULL,
>   					  ISAPNP_VENDOR('N', 'I', 'C'),
> -					  ISAPNP_FUNCTION(ni_boards[i].
> -							  isapnp_id), NULL);
> +					  ISAPNP_FUNCTION(ni_boards[i].isapnp_id),
> +					  NULL);
>   
>   		if (!isapnp_dev || !isapnp_dev->card)
>   			continue;
> 

I suggest splitting the expression just after the '=' to avoid going 
over 80 columns.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

  reply	other threads:[~2018-03-16 10:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 17:30 [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue Pratik Jain
2018-03-15 17:39 ` Greg KH
     [not found]   ` <CABbwmYcnDNcA70_-BhLkBcuK-77tk3BWKcvzQts6eWqu5_mMKA@mail.gmail.com>
2018-03-15 18:59     ` Pratik Jain
2018-03-16 10:17       ` Ian Abbott [this message]
2018-03-16 10:25         ` Pratik Jain
2018-03-16 10:29         ` Pratik Jain
2018-03-16 10:36           ` Dan Carpenter
2018-03-16 10:48             ` Pratik Jain
2018-03-16 10:55               ` Ian Abbott
     [not found]     ` <20180315193246.GA1565@kroah.com>
2018-03-15 19:49       ` Pratik Jain
2018-03-16  8:09         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dd4e733-b74a-c296-a554-3520a85e8ce2@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pratik.jain0509@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).