LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer
Date: Sun, 22 Aug 2021 00:14:51 -0700	[thread overview]
Message-ID: <2e0bea3524268f96a39506b3e5ea9f738c6aab27.camel@perches.com> (raw)
In-Reply-To: <877dgerrqw.fsf@codeaurora.org>

On Sun, 2021-08-22 at 08:08 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
> 
> > On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote:
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > 
> > > > Use %*ph format to print small buffer as hex string.
> > > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > Patch applied to wireless-drivers-next.git, thanks.
> > > 
> > > 502213fd8fca ray_cs: use %*ph to print small buffer
> > > 
> > 
> > There's one more of these in the same file but it's in an #ifdef 0 block...
> 
> I would rather remove the whole ifdef 0 block, patches welcome.
> 

It'd probably take you about 20 seconds if you do it yourself.

$ git grep -P -n '^\s*#\s*if\s+0\b' drivers/net/wireless/ray_cs.c
drivers/net/wireless/ray_cs.c:637:#if 0
drivers/net/wireless/ray_cs.c:2281:#if 0
drivers/net/wireless/ray_cs.c:2341:#if 0

Rather a bit more time if you want to do the whole kernel...

$ git grep -P -n '^\s*#\s*if\s+0\b' | wc -l
1558




      reply	other threads:[~2021-08-22  7:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 14:29 Andy Shevchenko
2021-08-21 17:14 ` Kalle Valo
2021-08-21 19:38   ` Joe Perches
2021-08-22  5:08     ` Kalle Valo
2021-08-22  7:14       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e0bea3524268f96a39506b3e5ea9f738c6aab27.camel@perches.com \
    --to=joe@perches.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).