From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE87C4320E for ; Sun, 22 Aug 2021 07:14:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EB966127B for ; Sun, 22 Aug 2021 07:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231592AbhHVHPh (ORCPT ); Sun, 22 Aug 2021 03:15:37 -0400 Received: from smtprelay0037.hostedemail.com ([216.40.44.37]:51066 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229934AbhHVHPg (ORCPT ); Sun, 22 Aug 2021 03:15:36 -0400 Received: from omf02.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 3553D18037BD8; Sun, 22 Aug 2021 07:14:54 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA id 09A5F1D42F4; Sun, 22 Aug 2021 07:14:52 +0000 (UTC) Message-ID: <2e0bea3524268f96a39506b3e5ea9f738c6aab27.camel@perches.com> Subject: Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer From: Joe Perches To: Kalle Valo Cc: Andy Shevchenko , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski Date: Sun, 22 Aug 2021 00:14:51 -0700 In-Reply-To: <877dgerrqw.fsf@codeaurora.org> References: <20210712142943.23981-1-andriy.shevchenko@linux.intel.com> <20210821171432.B996DC4360C@smtp.codeaurora.org> <293b9231af8b36bb9a24a11c689d33c7e89c3c4e.camel@perches.com> <877dgerrqw.fsf@codeaurora.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 09A5F1D42F4 X-Stat-Signature: ybkgy97sw4z5qypncs8n4fbpy78rcu97 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+yJGoCh/tebKAdOx3pd0yDij8KagAZkmo= X-HE-Tag: 1629616492-286889 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2021-08-22 at 08:08 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote: > > > Andy Shevchenko wrote: > > > > > > > Use %*ph format to print small buffer as hex string. > > > > > > > > Signed-off-by: Andy Shevchenko > > > > > > Patch applied to wireless-drivers-next.git, thanks. > > > > > > 502213fd8fca ray_cs: use %*ph to print small buffer > > > > > > > There's one more of these in the same file but it's in an #ifdef 0 block... > > I would rather remove the whole ifdef 0 block, patches welcome. > It'd probably take you about 20 seconds if you do it yourself. $ git grep -P -n '^\s*#\s*if\s+0\b' drivers/net/wireless/ray_cs.c drivers/net/wireless/ray_cs.c:637:#if 0 drivers/net/wireless/ray_cs.c:2281:#if 0 drivers/net/wireless/ray_cs.c:2341:#if 0 Rather a bit more time if you want to do the whole kernel... $ git grep -P -n '^\s*#\s*if\s+0\b' | wc -l 1558