LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Chanwoo Lee <cw9316.lee@samsung.com>,
	ulf.hansson@linaro.org, colyli@suse.de, axboe@kernel.dk,
	ebiggers@google.com, pcc@google.com, porzio@gmail.com,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
	dh0421.hwang@samsung.com, sh043.lee@samsung.com
Subject: Re: [PATCH] mmc: queue: Remove unused parameters(request_queue)
Date: Wed, 25 Aug 2021 07:46:23 +0300	[thread overview]
Message-ID: <2e292b9c-9b1e-dc3e-45f9-06beb31d79b6@intel.com> (raw)
In-Reply-To: <20210825003318.31574-1-cw9316.lee@samsung.com>

On 25/08/21 3:33 am, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> In function mmc_exit_request, the request_queue structure(*q) is not used.
> I remove the unnecessary code related to the request_queue structure.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
> ---
>  drivers/mmc/core/queue.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index cc3261777637..b742385361e4 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -219,7 +219,7 @@ static int __mmc_init_request(struct mmc_queue *mq, struct request *req,
>  	return 0;
>  }
>  
> -static void mmc_exit_request(struct request_queue *q, struct request *req)
> +static void mmc_exit_request(struct request *req)
>  {
>  	struct mmc_queue_req *mq_rq = req_to_mmc_queue_req(req);
>  
> @@ -236,9 +236,7 @@ static int mmc_mq_init_request(struct blk_mq_tag_set *set, struct request *req,
>  static void mmc_mq_exit_request(struct blk_mq_tag_set *set, struct request *req,
>  				unsigned int hctx_idx)
>  {
> -	struct mmc_queue *mq = set->driver_data;
> -
> -	mmc_exit_request(mq->queue, req);
> +	mmc_exit_request(req);

It seems this is the only caller of mmc_exit_request().  It is probably
leftover from before the switch to blk-mq.  However we might as well get rid
of it and just put the code directly into mmc_mq_exit_request().

The same applies to mmc_mq_init_request() and __mmc_init_request(), so might
as well tidy up those also.

>  }
>  
>  static blk_status_t mmc_mq_queue_rq(struct blk_mq_hw_ctx *hctx,
> 


      reply	other threads:[~2021-08-25  4:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210825004043epcas1p33ca4a682a765e1270258bba083fe66d6@epcas1p3.samsung.com>
2021-08-25  0:33 ` Chanwoo Lee
2021-08-25  4:46   ` Adrian Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e292b9c-9b1e-dc3e-45f9-06beb31d79b6@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=cw9316.lee@samsung.com \
    --cc=dh0421.hwang@samsung.com \
    --cc=ebiggers@google.com \
    --cc=grant.jung@samsung.com \
    --cc=jt77.jang@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=pcc@google.com \
    --cc=porzio@gmail.com \
    --cc=sh043.lee@samsung.com \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH] mmc: queue: Remove unused parameters(request_queue)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).