LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
Date: Tue, 30 Oct 2018 10:09:54 -0700	[thread overview]
Message-ID: <2e742a7e-5e1f-a5ac-0372-f0e10a3783d7@oracle.com> (raw)
In-Reply-To: <20181030111103.12110-1-marc.zyngier@arm.com>

10/30/2018 4:11 AM, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
Thanks Marc for the fix. Will send note to arm-soc folks
to pick this up for fixes and also stable.

Regards,
Santosh

  parent reply	other threads:[~2018-10-30 17:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 11:11 Marc Zyngier
2018-10-30 17:02 ` Florian Fainelli
2018-10-30 18:29   ` Marc Zyngier
2018-10-30 17:09 ` Santosh Shilimkar [this message]
2018-10-30 17:15 ` Santosh Shilimkar
2018-10-30 17:18 ` Santosh Shilimkar
2018-10-30 19:00   ` Greg Kroah-Hartman
2018-10-30 19:05     ` santosh.shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e742a7e-5e1f-a5ac-0372-f0e10a3783d7@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=ssantosh@kernel.org \
    --subject='Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).