LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
To: bhelgaas@google.com, lorenzo.pieralisi@arm.com,
	Joao.Pinto@synopsys.com, jingoohan1@gmail.com, kishon@ti.com,
	robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com
Subject: [PATCH v5 03/10] PCI: endpoint: functions/pci-epf-test: Add second entry
Date: Tue, 17 Apr 2018 15:34:21 +0100	[thread overview]
Message-ID: <2f0c370d4308380672bd4a5afcad58a385dcf21f.1523973931.git.gustavo.pimentel@synopsys.com> (raw)
In-Reply-To: <cover.1523973931.git.gustavo.pimentel@synopsys.com>
In-Reply-To: <cover.1523973931.git.gustavo.pimentel@synopsys.com>

Adds a seconds entry on the pci_epf_test_ids structure that disables the
linkup_notifier parameter on driver for the designware EP.

This allows designware EPs that doesn't have linkup notification signal
to work with pcitest.

Updates the binding documentation accordingly.

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
---
Change v2->v3:
 - Added second entry in pci_epf_test_ids structure.
 - Remove test_reg_bar field assignment on second entry.
Changes v3->v4:
 - Nothing changed, just to follow the patch set version.
Changes v4->v5:
 - Changed pci_epf_test_cfg2 to pci_epf_test_designware.

 Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++
 drivers/pci/endpoint/functions/pci-epf-test.c            | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt
index 3b68b95..b321f9d 100644
--- a/Documentation/PCI/endpoint/function/binding/pci-test.txt
+++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt
@@ -1,6 +1,8 @@
 PCI TEST ENDPOINT FUNCTION
 
 name: Should be "pci_epf_test" to bind to the pci_epf_test driver.
+name: Should be "pci_epf_designware" to bind to the pci_epf_test driver
+      with a custom configuration for the designware EP.
 
 Configurable Fields:
 vendorid	 : should be 0x104c
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index 7cef851..3f613d2 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf)
 	return 0;
 }
 
+static const struct pci_epf_test_data data_cfg2 = {
+	.linkup_notifier = false
+};
+
 static const struct pci_epf_device_id pci_epf_test_ids[] = {
 	{
 		.name = "pci_epf_test",
 	},
+	{
+		.name = "pci_epf_test_designware",
+		.driver_data = (kernel_ulong_t)&data_cfg2,
+	},
 	{},
 };
 
-- 
2.7.4

  parent reply	other threads:[~2018-04-17 14:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 14:34 [PATCH v5 00/10] Designware EP support and code clean up Gustavo Pimentel
2018-04-17 14:34 ` [PATCH v5 01/10] bindings: PCI: designware: Example update Gustavo Pimentel
2018-04-18 14:05   ` Rob Herring
2018-04-17 14:34 ` [PATCH v5 02/10] PCI: dwc: Add support for endpoint mode Gustavo Pimentel
2018-04-17 18:46   ` Joao Pinto
2018-04-17 14:34 ` Gustavo Pimentel [this message]
2018-04-18 14:03   ` [PATCH v5 03/10] PCI: endpoint: functions/pci-epf-test: Add second entry kbuild test robot
2018-04-17 14:34 ` [PATCH v5 04/10] bindings: PCI: designware: Add support for the EP in Designware driver Gustavo Pimentel
2018-04-17 14:34 ` [PATCH v5 05/10] PCI: Adds device ID for Synopsys Sample Endpoint Gustavo Pimentel
2018-04-18 13:40   ` Bjorn Helgaas
2018-04-17 14:34 ` [PATCH v5 06/10] misc: pci_endpoint_test: Add designware EP entry Gustavo Pimentel
2018-04-17 14:34 ` [PATCH v5 07/10] PCI: dwc: Define maximum number of vectors Gustavo Pimentel
2018-04-17 18:56   ` Joao Pinto
2018-04-17 14:34 ` [PATCH v5 08/10] PCI: dwc: Replace lower into upper case characters Gustavo Pimentel
2018-04-17 19:01   ` Joao Pinto
2018-04-17 14:34 ` [PATCH v5 09/10] PCI: dwc: Small computation improvement Gustavo Pimentel
2018-04-17 14:37   ` Jingoo Han
2018-04-17 19:05   ` Joao Pinto
2018-04-17 14:34 ` [PATCH v5 10/10] PCI: dwc: Replace magic number by defines Gustavo Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f0c370d4308380672bd4a5afcad58a385dcf21f.1523973931.git.gustavo.pimentel@synopsys.com \
    --to=gustavo.pimentel@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v5 03/10] PCI: endpoint: functions/pci-epf-test: Add second entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).