LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: "Andrew Morton" <akpm@linux-foundation.org>, bunk@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [2.6 patch] mm/page_alloc.c: cleanups
Date: Tue, 6 May 2008 07:58:32 +0900	[thread overview]
Message-ID: <2f11576a0805051558j19949eb7ma7e78d9c8ce6917a@mail.gmail.com> (raw)
In-Reply-To: <20080505141352.703dbee8.akpm@linux-foundation.org>

>  > >  that's a bug, surely?  I bet there are plenty of places which should be
>  > >  using this hint.
>  >
>  > Hm, as far as I investigate
>  >
>  > 1. nobody used free_cold_page() in kernel code tree.
>  > 2. free_cold_page() doesn't exported.
>  >
>  > I investigated to 2.6.25-mm1.
>  > I don't understand yet why you think plenty....
>
>  Any place in the kernel which frees a page which is probably cache-cold
>  should be using this function.  (Including any place which caused the page
>  to be evicted from CPU cache by placing it under DMA).

Ah, Agreed.

Adrian, Can you remove free_cold_page() change in your patch?

  reply	other threads:[~2008-05-05 22:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 18:25 Adrian Bunk
2008-05-05 20:24 ` KOSAKI Motohiro
2008-05-05 20:45   ` Andrew Morton
2008-05-05 20:59     ` KOSAKI Motohiro
2008-05-05 21:13       ` Andrew Morton
2008-05-05 22:58         ` KOSAKI Motohiro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-25 16:26 Adrian Bunk
2008-03-30 22:53 Adrian Bunk
2008-03-31 11:32 ` Peter Zijlstra
2008-04-14 18:14   ` Adrian Bunk
2008-02-25  0:09 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f11576a0805051558j19949eb7ma7e78d9c8ce6917a@mail.gmail.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: [2.6 patch] mm/page_alloc.c: cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).