LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Felix Kuehling <felix.kuehling@amd.com>,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/amdkfd: Slighly optimize 'init_doorbell_bitmap()'
Date: Tue, 23 Nov 2021 07:02:28 +0100	[thread overview]
Message-ID: <306b774e-6ee7-c976-a303-f566f7ba626c@wanadoo.fr> (raw)
In-Reply-To: <283c0b53-ff4e-85f8-4738-2d477365f458@amd.com>

Le 22/11/2021 à 22:44, Felix Kuehling a écrit :
> Am 2021-11-21 um 12:41 p.m. schrieb Christophe JAILLET:
>> The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
>> non-atomic '__set_bit()' function to save a few cycles as no concurrent
>> access can happen.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Thank you for the patches. I think the same sort of change (at least the
> allocation/freeing part) could be applied to the queue_slot_bitmap in
> kfd_process_queue_manager.c. Would you like to submit another revision
> of this patch series that handles that as well?

I'll send a v2 which will fix the missing ',' spotted by the kernel test 
robot and include kfd_process_queue_manager.c.

All my patches are compile tested (otherwise it is said bellow the ---). 
Looks like I missed this one :(.

CJ

> 
> Either way, this series is
> 
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> 
> 
>> ---
>> bitmap_set() could certainly also be use, but range checking would be
>> tricky.
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
>> index 172ee8763523..2e9d341062c4 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
>> @@ -1447,9 +1447,9 @@ static int init_doorbell_bitmap(struct qcm_process_device *qpd,
>>   
>>   	for (i = 0; i < KFD_MAX_NUM_OF_QUEUES_PER_PROCESS / 2; i++) {
>>   		if (i >= range_start && i <= range_end) {
>> -			set_bit(i, qpd->doorbell_bitmap);
>> -			set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
>> -				qpd->doorbell_bitmap);
>> +			__set_bit(i, qpd->doorbell_bitmap);
>> +			__set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
>> +				  qpd->doorbell_bitmap);
>>   		}
>>   	}
>>   
> 


      reply	other threads:[~2021-11-23  6:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 17:41 [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable Christophe JAILLET
2021-11-21 17:41 ` [PATCH 2/2] drm/amdkfd: Slighly optimize 'init_doorbell_bitmap()' Christophe JAILLET
2021-11-22 21:44   ` Felix Kuehling
2021-11-23  6:02     ` Christophe JAILLET [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=306b774e-6ee7-c976-a303-f566f7ba626c@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felix.kuehling@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2/2] drm/amdkfd: Slighly optimize '\''init_doorbell_bitmap()'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).