LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/hdsmart.h: fix goofups
Date: Mon, 18 Feb 2008 00:06:37 -0500	[thread overview]
Message-ID: <30744.1203311197@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 17 Feb 2008 12:17:20 EST." <alpine.LFD.1.00.0802171214380.3515@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said:

> if that header file isn't used by any kernel code, why bother having a
> check for __KERNEL__ in the first place?  it's being exported to
> userspace unchecked:
> 
>   include/linux/Kbuild:header-y += hdsmart.h
> 
> so why not just toss that check entirely?  otherwise, you're going to
> get a header file exported to userspace that has a superfluous
> __KERNEL__ test in it.

Umm... if the kernel isn't using it, why are we bothering to export it to
userspace at all?  Or is the kernel using something *else* that should be going
to userspace instead?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  parent reply	other threads:[~2008-02-18  5:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 17:07 Bartlomiej Zolnierkiewicz
2008-02-17 17:17 ` Robert P. J. Day
2008-02-17 17:40   ` Bartlomiej Zolnierkiewicz
2008-02-17 17:36     ` Adrian Bunk
2008-02-17 18:04       ` Bartlomiej Zolnierkiewicz
2008-02-17 17:53         ` Robert P. J. Day
2008-02-19 19:29         ` [2.6 patch] remove include/linux/hdsmart.h Adrian Bunk
2008-02-19 21:51           ` Bartlomiej Zolnierkiewicz
2008-02-18  5:06   ` Valdis.Kletnieks [this message]
2008-02-18  9:50     ` [PATCH] linux/hdsmart.h: fix goofups Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30744.1203311197@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    --subject='Re: [PATCH] linux/hdsmart.h: fix goofups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).