LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Andrew Morton <akpm@linux-foundation.org>,
	Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.
Date: Mon, 25 Feb 2008 12:59:29 -0500	[thread overview]
Message-ID: <30804.1203962369@turing-police.cc.vt.edu> (raw)

The symbol 'mcount' has EXPORT_SYMBOL_GPL attached to it.  This is because
"things that use this symbol are too chummy with kernel internals to not be
derivative".  However, the symbol may or may not actually be referenced by a
given module, depending on the setting of CONFIG_FTRACE.  This leads to an
interesting result:  The module may or may not be too chummy depending on a
variable outside its control, and the module source code doesn't have any say
in the matter.  So we have a .c file that *is* a derivative work if the kernel
is built one way, and is *not* if the kernel is built another.  Worse yet,
it *also* depends at runtime on the setting of /proc/sys/kernel/ftrace_enabled

But it's the SAME EXACT SOURCE.  And since the source file isn't called
schrodinger.c, I believe the following patch is in order..

(As an aside, arch/um/kernel/gprof_syms.c already lists mcount as a
SYMBOL, not a SYMBOL_GPL - yet another inconsistency.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
--- linux-2.6.25-rc2-mm1/kernel/trace/ftrace.c.dist	2008-02-16 23:34:36.000000000 -0500
+++ linux-2.6.25-rc2-mm1/kernel/trace/ftrace.c	2008-02-25 12:00:57.000000000 -0500
@@ -44,7 +44,7 @@ static struct ftrace_ops *ftrace_list __
 ftrace_func_t ftrace_trace_function __read_mostly = ftrace_stub;
 
 /* mcount is defined per arch in assembly */
-EXPORT_SYMBOL_GPL(mcount);
+EXPORT_SYMBOL(mcount);
 
 notrace void ftrace_list_func(unsigned long ip, unsigned long parent_ip)
 {


             reply	other threads:[~2008-02-25 18:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 17:59 Valdis.Kletnieks [this message]
2008-02-25 18:23 ` Steven Rostedt
2008-02-25 18:19   ` Alan Cox
2008-02-25 19:27     ` Adrian Bunk
2008-02-25 19:48       ` Alan Cox
2008-02-25 20:09         ` Adrian Bunk
2008-02-25 20:38           ` Alan Cox
2008-02-25 21:17       ` Valdis.Kletnieks
2008-02-26  1:30   ` David Schwartz
2008-02-26 12:29     ` Alan Cox
2008-02-26 15:43     ` Krzysztof Halasa
2008-02-26 17:04       ` Krzysztof Halasa
2008-02-26 17:21         ` Alan Cox
2008-02-26 17:44           ` Krzysztof Halasa
2008-02-26 18:04             ` Alan Cox
2008-02-26 18:19       ` David Schwartz
2008-02-26 23:13         ` Krzysztof Halasa
2008-02-26 23:35           ` David Schwartz
2008-02-27  0:05             ` Krzysztof Halasa
2008-02-27  0:28               ` David Schwartz
2008-02-27 10:31           ` Alan Cox
2008-02-27 10:55             ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30804.1203962369@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=acme@ghostprotocols.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=srostedt@redhat.com \
    --subject='Re: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).